Adds domain names for all qualified CT logs

net/cert/ct_objects_extractor_unittest.cc

Index: net/cert/ct_objects_extractor_unittest.cc
diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc
index e8718bd8b85152d932bc05dfd140b3e4aa673d0c..389fd663e77a813c904ce2ec499918206bb0a916 100644
--- a/net/cert/ct_objects_extractor_unittest.cc
+++ b/net/cert/ct_objects_extractor_unittest.cc
@@ -32,7 +32,7 @@ class CTObjectsExtractorTest : public ::testing::Test {
                                                   der_test_cert.length());
 
     log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog",
-                                 "https://ct.example.com");
+                                 "https://ct.example.com", "");

[Ryan Sleevi, 2016/07/18 19:06:38]

std::string(), not ""

[Rob Percival, 2016/07/18 22:20:06]

Is that safe? Create takes these parameters as StringPieces. A string literal is
fine, but I'd have thought a temporary std::string would not be.

[Ryan Sleevi, 2016/07/18 23:14:47]

You're guaranteed that the temporary std::string() will last for the entire
full-statement (which would include the full assignment operation). Because
::Create() goes StringPiece and makes a copy of it (via .as_string()), it's
safe.

That said, I missed that the API contract was StringPiece here and not string;
in this case, use base::StringPiece() rather than the ""

     ASSERT_TRUE(log_);
   }