Adds domain names for all qualified CT logs

net/cert/ct_objects_extractor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_objects_extractor.h"
 
 #include "base/files/file_path.h"
 #include "net/cert/ct_log_verifier.h"
 #include "net/cert/ct_serialization.h"
 #include "net/cert/signed_certificate_timestamp.h"
@@ skipping 14 matching lines @@
         CreateCertificateListFromFile(GetTestCertsDirectory(),
                                       "ct-test-embedded-cert.pem",
                                       X509Certificate::FORMAT_AUTO);
     ASSERT_EQ(2u, precert_chain_.size());
 
     std::string der_test_cert(ct::GetDerEncodedX509Cert());
     test_cert_ = X509Certificate::CreateFromBytes(der_test_cert.data(),
                                                   der_test_cert.length());
 
     log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog",
-                                 "https://ct.example.com");
+                                 "https://ct.example.com", "");

[Ryan Sleevi, 2016/07/18 19:06:38]

std::string(), not ""

[Rob Percival, 2016/07/18 22:20:06]

Is that safe? Create takes these parameters as StringPieces. A string literal is
fine, but I'd have thought a temporary std::string would not be.

[Ryan Sleevi, 2016/07/18 23:14:47]

You're guaranteed that the temporary std::string() will last for the entire
full-statement (which would include the full assignment operation). Because
::Create() goes StringPiece and makes a copy of it (via .as_string()), it's
safe.

That said, I missed that the API contract was StringPiece here and not string;
in this case, use base::StringPiece() rather than the ""

     ASSERT_TRUE(log_);
   }
 
   void ExtractEmbeddedSCT(scoped_refptr<X509Certificate> cert,
                           scoped_refptr<SignedCertificateTimestamp>* sct) {
     std::string sct_list;
     EXPECT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
 
     std::vector<base::StringPiece> parsed_scts;
     base::StringPiece sct_list_sp(sct_list);
@@ skipping 127 matching lines @@
   std::string extracted_sct_list;
   // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|.
   EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
       test_cert_->os_cert_handle(), subject_cert->serial_number(),
       ocsp_response, &extracted_sct_list));
 }
 
 }  // namespace ct
 
 }  // namespace net