Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: net/cert/ct_log_verifier_unittest.cc

Issue 2108833005: Adds domain names for all qualified CT logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updates command-line documentation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_log_verifier_unittest.cc
diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc
index 9221f0663272d0c0d47438ca6e1648113e8f3115..754d3e39073c50f89c3c83b1d3d623a7ef782659 100644
--- a/net/cert/ct_log_verifier_unittest.cc
+++ b/net/cert/ct_log_verifier_unittest.cc
@@ -140,10 +140,11 @@ class CTLogVerifierTest : public ::testing::Test {
void SetUp() override {
log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog",
- "https://ct.example.com");
+ "https://ct.example.com", "ct.example.com");
ASSERT_TRUE(log_);
- ASSERT_EQ(log_->key_id(), ct::GetTestPublicKeyId());
+ ASSERT_EQ(ct::GetTestPublicKeyId(), log_->key_id());
+ ASSERT_EQ("ct.example.com", log_->dns_domain());
}
// Given a consistency proof between two snapshots of the tree, asserts that
@@ -317,8 +318,8 @@ TEST_F(CTLogVerifierTest, ExcessDataInPublicKey) {
std::string key = ct::GetTestPublicKey();
key += "extra";
- scoped_refptr<const CTLogVerifier> log =
- CTLogVerifier::Create(key, "testlog", "https://ct.example.com");
+ scoped_refptr<const CTLogVerifier> log = CTLogVerifier::Create(
+ key, "testlog", "https://ct.example.com", "ct.example.com");
EXPECT_FALSE(log);
}

Powered by Google App Engine
This is Rietveld 408576698