Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2108643006: crimson server: Implemented SelectHost and InsertHost (Closed)

Created:
4 years, 5 months ago by pgervais
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@mactohex
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

crimson server: Implemented SelectHost and InsertHost This is a first implementation, several consistency checks are still missing. BUG=621589 Committed: https://chromium.googlesource.com/infra/infra/+/1bb82fcc08df8b71f2c8d8e1c37fed31e46552e2

Patch Set 1 #

Patch Set 2 : Reordered proto fields #

Patch Set 3 : Added NULL support for boot class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -79 lines) Patch
M go/src/infra/crimson/proto/crimson.proto View 1 2 chunks +26 lines, -0 lines 0 comments Download
M go/src/infra/crimson/proto/crimson.pb.go View 1 8 chunks +170 lines, -18 lines 0 comments Download
M go/src/infra/crimson/proto/crimsonserver_dec.go View 1 chunk +16 lines, -0 lines 0 comments Download
M go/src/infra/crimson/proto/pb.discovery.go View 1 1 chunk +102 lines, -59 lines 0 comments Download
M go/src/infra/crimson/server/crimsondb/crimsondb.go View 1 2 1 chunk +204 lines, -0 lines 0 comments Download
M go/src/infra/crimson/server/crimsondb/crimsondb_test.go View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
M go/src/infra/crimson/server/frontend/crimson_service.go View 1 chunk +14 lines, -0 lines 0 comments Download
M go/src/infra/crimson/sql/schema.sql View 1 chunk +11 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
pgervais
Started creating methods to create and query hosts. As the description says it's a first ...
4 years, 5 months ago (2016-06-29 18:56:59 UTC) #2
Sergey Berezin
lgtm
4 years, 5 months ago (2016-06-29 22:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108643006/40001
4 years, 5 months ago (2016-06-30 15:58:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/1bb82fcc08df8b71f2c8d8e1c37fed31e46552e2
4 years, 5 months ago (2016-06-30 16:14:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:14:54 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698