Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2105213002: Created MacAddrStringToHexString and reverse (Closed)

Created:
4 years, 5 months ago by pgervais
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@crimson-add-host
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : More tests to get coverage up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -25 lines) Patch
M go/src/infra/crimson/server/crimsondb/crimsondb.go View 1 2 3 chunks +49 lines, -5 lines 0 comments Download
M go/src/infra/crimson/server/crimsondb/crimsondb_test.go View 1 2 3 chunks +105 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pgervais
Necessary functions to convert human-readable strings into MySQL-friendly representations.
4 years, 5 months ago (2016-06-29 00:15:29 UTC) #2
Vadim Sh.
lgtm
4 years, 5 months ago (2016-06-29 00:26:15 UTC) #3
Sergey Berezin
lgtm
4 years, 5 months ago (2016-06-29 01:05:11 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2103303002 Patch 40001). Please resolve the dependency and ...
4 years, 5 months ago (2016-06-29 01:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105213002/20001
4 years, 5 months ago (2016-06-29 23:13:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2705)
4 years, 5 months ago (2016-06-29 23:21:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105213002/40001
4 years, 5 months ago (2016-06-30 00:10:02 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/a47ac9053d5b303c84ad868d76b7b43e974fa9b8
4 years, 5 months ago (2016-06-30 00:24:06 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:24:07 UTC) #18
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698