Crimson client: created add-host and query-host

Crimson client: created add-host and query-host

BUG=621589
Committed: https://chromium.googlesource.com/infra/infra/+/44aea597cd3cf54e5ac71663fb7f2ca316c4628f

[pgervais, 2016-06-29 22:26:20]

pgervais@chromium.org changed reviewers:
+ sergeyberezin@chromium.org, vadimsh@chromium.org

[pgervais, 2016-06-29 22:26:21]

Client-side CL corresponding to https://codereview.chromium.org/2108643006/

ptal

[Sergey Berezin (google), 2016-06-30 23:52:15]

sergeyberezin@google.com changed reviewers:
+ sergeyberezin@google.com

[Sergey Berezin (google), 2016-06-30 23:52:15]

LGTM. I'm assuming tests are postponed to later CLs.

[Vadim Sh., 2016-06-30 23:58:12]

lgtm

https://codereview.chromium.org/2110963002/diff/1/go/src/infra/crimson/cmd/cm...
File go/src/infra/crimson/cmd/cmdhelper/cmdhelper.go (right):

https://codereview.chromium.org/2110963002/diff/1/go/src/infra/crimson/cmd/cm...
go/src/infra/crimson/cmd/cmdhelper/cmdhelper.go:352: jsonBytes, err :=
json.Marshal(hostList.Hosts)
nit: consider using https://golang.org/pkg/encoding/json/#MarshalIndent instead
(with indent == "  "). Otherwise it may be too dense.

[pgervais, 2016-07-01 01:01:00]

https://codereview.chromium.org/2110963002/diff/1/go/src/infra/crimson/cmd/cm...
File go/src/infra/crimson/cmd/cmdhelper/cmdhelper.go (right):

https://codereview.chromium.org/2110963002/diff/1/go/src/infra/crimson/cmd/cm...
go/src/infra/crimson/cmd/cmdhelper/cmdhelper.go:352: jsonBytes, err :=
json.Marshal(hostList.Hosts)
On 2016/06/30 23:58:12, Vadim Sh. wrote:
> nit: consider using https://golang.org/pkg/encoding/json/#MarshalIndent
instead
> (with indent == "  "). Otherwise it may be too dense.

Done.

[pgervais, 2016-07-01 01:01:46]

On 2016/06/30 23:52:15, Sergey Berezin (google) wrote:
> LGTM. I'm assuming tests are postponed to later CLs.

Ahem. Completely forgot those :-) This CL is blocking many others, I'll add
tests in another CL as you suggested.

[pgervais, 2016-07-01 01:01:50]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2016-07-01 01:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
vadimsh@chromium.org, sergeyberezin@google.com
Link to the patchset: https://codereview.chromium.org/2110963002/#ps20001
(title: "JSON is printed indented")

[commit-bot: I haz the power, 2016-07-01 01:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 01:17:57]

Description was changed from

==========
Crimson client: created add-host and query-host

BUG=621589
==========

to

==========
Crimson client: created add-host and query-host

BUG=621589

Committed:
https://chromium.googlesource.com/infra/infra/+/44aea597cd3cf54e5ac71663fb7f2...
==========

[commit-bot: I haz the power, 2016-07-01 01:17:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/44aea597cd3cf54e5ac71663fb7f2...