ServiceWorker: Add an API to fallback to renderer for CORS preflight

content/browser/service_worker/service_worker_url_request_job.h

Index: content/browser/service_worker/service_worker_url_request_job.h
diff --git a/content/browser/service_worker/service_worker_url_request_job.h b/content/browser/service_worker/service_worker_url_request_job.h
index 029871bed969260948766f54e73c318123c609b3..a5487ce780090145f42afb89412bde4563c0f15b 100644
--- a/content/browser/service_worker/service_worker_url_request_job.h
+++ b/content/browser/service_worker/service_worker_url_request_job.h
@@ -104,6 +104,7 @@ class CONTENT_EXPORT ServiceWorkerURLRequestJob
 
   // Sets the response type.
   void FallbackToNetwork();
+  void FallbackToNetworkOrRenderer();

[falken, 2016/07/04 08:23:02]

Please document why the caller should use ToNetwork vs ToNetworkOrRenderer.

[shimazu, 2016/07/05 03:33:57]

Done.

   void ForwardToServiceWorker();
 
   bool ShouldFallbackToNetwork() const {
@@ -156,6 +157,7 @@ class CONTENT_EXPORT ServiceWorkerURLRequestJob
   enum ResponseType {
     NOT_DETERMINED,
     FALLBACK_TO_NETWORK,
+    FALLBACK_TO_RENDERER,  // Use this when falling back with CORS check
     FORWARD_TO_SERVICE_WORKER,
   };
 
@@ -199,6 +201,19 @@ class CONTENT_EXPORT ServiceWorkerURLRequestJob
   // Creates and commits a response header indicating error.
   void DeliverErrorResponse();
 
+  // Restarts this job to fallback to network.
+  // This can be called after StartRequest.
+  void FinalizeToFallbackToNetwork();

[falken, 2016/07/04 08:23:02]

"FinalizeTo" is a bit strange grammar. "FinalizeTo -> "Finalize". Better yet,
maybe "CommitFallback*" similar to the "CommitResponseHeader" function.

[shimazu, 2016/07/05 03:33:57]

Sorry, what do you mean for the latter sentence?

(If my understanding is correct, I think "Finalize" is better than "Commit"
because it's clearer to show here is the end of this job.)

[falken, 2016/07/05 06:49:28]

Hm, OK. Either one is OK. Finalize means the same thing as Commit to me... and
since there is already a Commit* function, it'd be consistent to also use Commit
here. Finalize didn't really imply end of job to me.

[shimazu, 2016/07/06 06:27:35]

Done.

+
+  // Sends back a response with fall_back_required set as true to trigger
+  // subsequent network requests with CORS checking.
+  // This can be called after StartRequest.
+  void FinalizeToFallbackToRenderer();
+
+  // true if need to send back a response with fall_back_required set as true to

[falken, 2016/07/04 08:23:02]

super nit: First letter should be capitalized (see git gs "// true" vs "//
True").

[shimazu, 2016/07/05 03:33:57]

Done.

+  // trigger subsequent network requests with CORS checking.
+  bool IsNeedToFallbackToRenderer() const;

[falken, 2016/07/04 08:23:02]

"IsNeedTo" -> "Is*Needed" (see git gs "IsNeedTo" vs git gs "Is.*Needed")

[shimazu, 2016/07/05 03:33:57]

Done.

+
   // For UMA.
   void SetResponseBodyType(ResponseBodyType type);
   bool ShouldRecordResult();