content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 2108573002: ServiceWorker: Add an API to fallback to renderer for CORS preflight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2108573002: ServiceWorker: Add an API to fallback to renderer for CORS preflight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add FallbackToNetworkOrRenderer and move a test to another CL Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_url_request_job.h » ('j') | content/browser/service_worker/service_worker_url_request_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index e45ca4c7d3f425d276d0c548aa33c3be1e74b974..9bf56fd1fd1f37d1e848cdb5154dbd82753c1261 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -285,7 +285,7 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(

if (version != registration->active_version() ||

version->status() != ServiceWorkerVersion::ACTIVATED ||

!provider_host_) {

- job_->FallbackToNetwork();

+ job_->FallbackToNetworkOrRenderer();

return;

}

@@ -309,7 +309,7 @@ void ServiceWorkerControlleeRequestHandler::DidUpdateRegistration(

return;

if (!context_) {

- job_->FallbackToNetwork();

+ job_->FallbackToNetworkOrRenderer();

return;

}

if (status != SERVICE_WORKER_OK ||

@@ -342,7 +342,7 @@ void ServiceWorkerControlleeRequestHandler::OnUpdatedVersionStatusChanged(

return;

if (!context_) {

- job_->FallbackToNetwork();

+ job_->FallbackToNetworkOrRenderer();

return;

}

if (version->status() == ServiceWorkerVersion::ACTIVATED ||