ServiceWorker: Add an API to fallback to renderer for CORS preflight

content/browser/service_worker/service_worker_url_request_job.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_URL_REQUEST_JOB_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_URL_REQUEST_JOB_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 86 matching lines @@
       RequestContextType request_context_type,
       RequestContextFrameType frame_type,
       scoped_refptr<ResourceRequestBodyImpl> body,
       ServiceWorkerFetchType fetch_type,
       Delegate* delegate);
 
   ~ServiceWorkerURLRequestJob() override;
 
   // Sets the response type.
   void FallbackToNetwork();
+  void FallbackToNetworkOrRenderer();

[falken, 2016/07/04 08:23:02]

Please document why the caller should use ToNetwork vs ToNetworkOrRenderer.

[shimazu, 2016/07/05 03:33:57]

Done.

   void ForwardToServiceWorker();
 
   bool ShouldFallbackToNetwork() const {
     return response_type_ == FALLBACK_TO_NETWORK;
   }
   bool ShouldForwardToServiceWorker() const {
     return response_type_ == FORWARD_TO_SERVICE_WORKER;
   }
 
   // net::URLRequestJob overrides:
@@ skipping 32 matching lines @@
   void OnStreamRegistered(Stream* stream) override;
 
   base::WeakPtr<ServiceWorkerURLRequestJob> GetWeakPtr();
 
  private:
   class BlobConstructionWaiter;
 
   enum ResponseType {
     NOT_DETERMINED,
     FALLBACK_TO_NETWORK,
+    FALLBACK_TO_RENDERER,  // Use this when falling back with CORS check
     FORWARD_TO_SERVICE_WORKER,
   };
 
   enum ResponseBodyType {
     UNKNOWN,
     BLOB,
     STREAM,
   };
 
   // We start processing the request if Start() is called AND response_type_
@@ skipping 23 matching lines @@
                             const std::string& status_text,
                             const ServiceWorkerHeaderMap& headers);
 
   // Creates |http_response_info_| using |http_response_headers_| and calls
   // NotifyHeadersComplete.
   void CommitResponseHeader();
 
   // Creates and commits a response header indicating error.
   void DeliverErrorResponse();
 
+  // Restarts this job to fallback to network.
+  // This can be called after StartRequest.
+  void FinalizeToFallbackToNetwork();

[falken, 2016/07/04 08:23:02]

"FinalizeTo" is a bit strange grammar. "FinalizeTo -> "Finalize". Better yet,
maybe "CommitFallback*" similar to the "CommitResponseHeader" function.

[shimazu, 2016/07/05 03:33:57]

Sorry, what do you mean for the latter sentence?

(If my understanding is correct, I think "Finalize" is better than "Commit"
because it's clearer to show here is the end of this job.)

[falken, 2016/07/05 06:49:28]

Hm, OK. Either one is OK. Finalize means the same thing as Commit to me... and
since there is already a Commit* function, it'd be consistent to also use Commit
here. Finalize didn't really imply end of job to me.

[shimazu, 2016/07/06 06:27:35]

Done.

+
+  // Sends back a response with fall_back_required set as true to trigger
+  // subsequent network requests with CORS checking.
+  // This can be called after StartRequest.
+  void FinalizeToFallbackToRenderer();
+
+  // true if need to send back a response with fall_back_required set as true to

[falken, 2016/07/04 08:23:02]

super nit: First letter should be capitalized (see git gs "// true" vs "//
True").

[shimazu, 2016/07/05 03:33:57]

Done.

+  // trigger subsequent network requests with CORS checking.
+  bool IsNeedToFallbackToRenderer() const;

[falken, 2016/07/04 08:23:02]

"IsNeedTo" -> "Is*Needed" (see git gs "IsNeedTo" vs git gs "Is.*Needed")

[shimazu, 2016/07/05 03:33:57]

Done.

+
   // For UMA.
   void SetResponseBodyType(ResponseBodyType type);
   bool ShouldRecordResult();
   void RecordResult(ServiceWorkerMetrics::URLRequestJobResult result);
   void RecordStatusZeroResponseError(
       blink::WebServiceWorkerResponseError error);
 
   // Releases the resources for streaming.
   void ClearStream();
 
@@ skipping 73 matching lines @@
   EmbeddedWorkerStatus initial_worker_status_ = EmbeddedWorkerStatus::STOPPED;
 
   base::WeakPtrFactory<ServiceWorkerURLRequestJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerURLRequestJob);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_URL_REQUEST_JOB_H_