Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2108033005: Specify WTF:: prefix for bind() (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, tzik, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, eric.carlson_apple.com, kinuko+worker_chromium.org, kinuko+watch, blink-reviews-wtf_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, mvanouwerkerk+watch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, blink-reviews, f(malita), ajuma+watch_chromium.org, blink-worker-reviews_chromium.org, Mads Ager (chromium), Peter Beverloo, sof, jbroman, timvolodine, loading-reviews_chromium.org, krit, nhiroki, loading-reviews+fetch_chromium.org, Nate Chapin, danakj+watch_chromium.org, michaeln, tyoshino+watch_chromium.org, feature-media-reviews_chromium.org, ajuma+watch-canvas_chromium.org, serviceworker-reviews, falken, mlamouri+watch-blink_chromium.org, kinuko+serviceworker, oilpan-reviews, horo+watch_chromium.org, Stephen Chennney, kouhei+heap_chromium.org, kinuko+fileapi, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify WTF:: prefix for bind() To avoid ambiguous resolutions to std::bind() (due to ADL and std::unique_ptr), this CL removes |using WTF::bind| and adds the WTF:: prefix to bind() where needed. BUG=624668 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c Cr-Commit-Position: refs/heads/master@{#403094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -96 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 16 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108033005/1
4 years, 5 months ago (2016-06-30 03:36:15 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 04:59:02 UTC) #5
hiroshige
PTAL.
4 years, 5 months ago (2016-06-30 05:05:00 UTC) #8
tzik
lgtm
4 years, 5 months ago (2016-06-30 05:11:13 UTC) #10
haraken
LGTM
4 years, 5 months ago (2016-06-30 05:17:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108033005/1
4 years, 5 months ago (2016-06-30 05:25:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 05:29:29 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 05:29:38 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 05:31:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c
Cr-Commit-Position: refs/heads/master@{#403094}

Powered by Google App Engine
This is Rietveld 408576698