third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 2108033005: Specify WTF:: prefix for bind()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2108033005: Specify WTF:: prefix for bind() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp ('k') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index 40f8e5b63e904b707aa94b523c2f101a6b7b8667..0052c3185ccaccd8156342f43f603e053a8907d5 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -423,14 +423,14 @@ void Geolocation::requestPermission()

m_geolocationPermission = PermissionRequested;

frame->serviceRegistry()->connectToRemoteService(

mojo::GetProxy(&m_permissionService));

- m_permissionService.set_connection_error_handler(createBaseCallback(bind(&Geolocation::onPermissionConnectionError, wrapWeakPersistent(this))));

+ m_permissionService.set_connection_error_handler(createBaseCallback(WTF::bind(&Geolocation::onPermissionConnectionError, wrapWeakPersistent(this))));

// Ask the embedder: it maintains the geolocation challenge policy itself.

m_permissionService->RequestPermission(

mojom::blink::PermissionName::GEOLOCATION,

getExecutionContext()->getSecurityOrigin()->toString(),

UserGestureIndicator::processingUserGesture(),

- createBaseCallback(bind(&Geolocation::onGeolocationPermissionUpdated, wrapPersistent(this))));

+ createBaseCallback(WTF::bind(&Geolocation::onGeolocationPermissionUpdated, wrapPersistent(this))));

}

void Geolocation::makeSuccessCallbacks()

@@ -495,7 +495,7 @@ void Geolocation::updateGeolocationServiceConnection()

return;

frame()->serviceRegistry()->connectToRemoteService(mojo::GetProxy(&m_geolocationService));

- m_geolocationService.set_connection_error_handler(createBaseCallback(bind(&Geolocation::onGeolocationConnectionError, wrapWeakPersistent(this))));

+ m_geolocationService.set_connection_error_handler(createBaseCallback(WTF::bind(&Geolocation::onGeolocationConnectionError, wrapWeakPersistent(this))));

if (m_enableHighAccuracy)

m_geolocationService->SetHighAccuracy(true);

queryNextPosition();

@@ -503,7 +503,7 @@ void Geolocation::updateGeolocationServiceConnection()

void Geolocation::queryNextPosition()

{

- m_geolocationService->QueryNextPosition(createBaseCallback(bind(&Geolocation::onPositionUpdated, wrapPersistent(this))));

+ m_geolocationService->QueryNextPosition(createBaseCallback(WTF::bind(&Geolocation::onPositionUpdated, wrapPersistent(this))));

}

void Geolocation::onPositionUpdated(mojom::blink::GeopositionPtr position)