Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2110363002: Rename SameThreadClosure to Closure (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
haraken, kinuko, tzik
CC:
chromium-reviews, tzik, blink-reviews-platform-graphics_chromium.org, dshwang, apavlov+blink_chromium.org, kinuko+worker_chromium.org, blink-reviews-wtf_chromium.org, rwlbuis, caseq+blink_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, ajuma+watch_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, Mads Ager (chromium), jbroman, lushnikov+blink_chromium.org, danakj+watch_chromium.org, krit, nhiroki, piman+watch_chromium.org, Stephen Chennney, ajuma+watch-canvas_chromium.org, scheduler-bugs_chromium.org, falken, pfeldman+blink_chromium.org, f(malita), oilpan-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, Mikhail, kouhei+heap_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@TRV_ExplicitWTFBind
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SameThreadClosure to Closure BUG=624668 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884 Cr-Commit-Position: refs/heads/master@{#403287}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add WTF:: to Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -48 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Microtask.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Microtask.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/ContentSettingCallbacks.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/ContentSettingCallbacks.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/WebTaskRunner.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/FunctionalTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110363002/1
4 years, 5 months ago (2016-06-30 05:10:58 UTC) #2
hiroshige
PTAL.
4 years, 5 months ago (2016-06-30 05:25:18 UTC) #5
hiroshige
+kinuko@
4 years, 5 months ago (2016-06-30 05:26:25 UTC) #7
haraken
LGTM
4 years, 5 months ago (2016-06-30 05:28:39 UTC) #8
tzik
https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h File third_party/WebKit/Source/wtf/Functional.h (right): https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h#newcode275 third_party/WebKit/Source/wtf/Functional.h:275: using WTF::Closure; Can we remove `using WTF::Closure;` here and ...
4 years, 5 months ago (2016-06-30 06:40:32 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 06:42:17 UTC) #11
kinuko
On 2016/06/30 06:40:32, tzik wrote: > https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h > File third_party/WebKit/Source/wtf/Functional.h (right): > > https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h#newcode275 > ...
4 years, 5 months ago (2016-06-30 06:52:23 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110363002/40001
4 years, 5 months ago (2016-06-30 11:34:31 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110363002/60001
4 years, 5 months ago (2016-06-30 11:35:50 UTC) #20
hiroshige
https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h File third_party/WebKit/Source/wtf/Functional.h (right): https://codereview.chromium.org/2110363002/diff/1/third_party/WebKit/Source/wtf/Functional.h#newcode275 third_party/WebKit/Source/wtf/Functional.h:275: using WTF::Closure; On 2016/06/30 06:40:32, tzik wrote: > Can ...
4 years, 5 months ago (2016-06-30 11:38:43 UTC) #21
tzik
lgtm
4 years, 5 months ago (2016-06-30 11:40:11 UTC) #22
kinuko
lgtm/2
4 years, 5 months ago (2016-06-30 13:13:42 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 14:11:49 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110363002/60001
4 years, 5 months ago (2016-06-30 21:07:46 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-06-30 21:14:17 UTC) #29
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 21:14:40 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:16:48 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884
Cr-Commit-Position: refs/heads/master@{#403287}

Powered by Google App Engine
This is Rietveld 408576698