Generalize DartSdkManager to support embedder SDKs

Generalize DartSdkManager to support embedder SDKs

R=pquitslund@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c5213a0779886d1d9104c6995b62b763189182b

[Brian Wilkerson, 2016-06-28 14:58:20]

brianwilkerson@google.com changed reviewers:
+ pquitslund@google.com, scheglov@google.com

[Brian Wilkerson, 2016-06-28 14:58:21]

This should enable us to share SDKs created from embedder.yaml files, which
should help performance.

AFAIK, we don't currently have a benchmark showing performance for this case.
Should we add one before this is committed?

[scheglov, 2016-06-28 15:24:22]

LGTM

If you will add add a benchmark, see
pkg/analysis_server/benchmark/perf/benchmark_scenario.dart for the list existing
of scenarios.
It might be start_waitInitialAnalysis_shutdown with a set of roots which use
embedder.yaml files.


On 2016/06/28 14:58:21, Brian Wilkerson wrote:
> This should enable us to share SDKs created from embedder.yaml files, which
> should help performance.
> 
> AFAIK, we don't currently have a benchmark showing performance for this case.
> Should we add one before this is committed?

[pquitslund, 2016-06-28 16:31:05]

LGTM!

[Brian Wilkerson, 2016-06-28 20:49:00]

Description was changed from

==========
Generalize DartSdkManager to support embedder SDKs
==========

to

==========
Generalize DartSdkManager to support embedder SDKs

R=pquitslund@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c5213a0779886d1d9104c6995b62b763189182b
==========

[Brian Wilkerson, 2016-06-28 20:49:01]

Committed patchset #1 (id:1) manually as
9c5213a0779886d1d9104c6995b62b763189182b (presubmit successful).