pkg/analysis_server/test/analysis_server_test.dart - Issue 2107793002: Generalize DartSdkManager to support embedder SDKs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis_server_test.dart

Issue 2107793002: Generalize DartSdkManager to support embedder SDKs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/test/analysis_server_test.dart

diff --git a/pkg/analysis_server/test/analysis_server_test.dart b/pkg/analysis_server/test/analysis_server_test.dart

index b05cf9c189ad7266c63fe62fb7435e5be7124618..eaea9a6521ea7dad550eda3d55c56b5ac1acbce7 100644

--- a/pkg/analysis_server/test/analysis_server_test.dart

+++ b/pkg/analysis_server/test/analysis_server_test.dart

@@ -19,6 +19,7 @@ import 'package:analyzer/instrumentation/instrumentation.dart';

import 'package:analyzer/source/package_map_resolver.dart';

import 'package:analyzer/src/generated/engine.dart';

import 'package:analyzer/src/generated/java_engine.dart';

+import 'package:analyzer/src/generated/sdk.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:plugin/manager.dart';

import 'package:plugin/plugin.dart';

@@ -144,7 +145,7 @@ import "../foo/foo.dart";

null,

plugin,

new AnalysisServerOptions(),

- (_) => new MockSdk(),

+ new DartSdkManager('', false, (_) => new MockSdk()),

InstrumentationService.NULL_SERVICE,

rethrowExceptions: true);

processRequiredPlugins();