pkg/analysis_server/lib/src/server/driver.dart - Issue 2107793002: Generalize DartSdkManager to support embedder SDKs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 2107793002: Generalize DartSdkManager to support embedder SDKs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/server/driver.dart

diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart

index f78fc6169d4be6372d6cfd7955a0646d9802ceb7..b6c878f06ec24d1c59db9def08df2f7c0138b5c3 100644

--- a/pkg/analysis_server/lib/src/server/driver.dart

+++ b/pkg/analysis_server/lib/src/server/driver.dart

@@ -448,7 +448,8 @@ class Driver implements ServerStarter {

socketServer = new SocketServer(

analysisServerOptions,

- defaultSdkCreator,

+ new DartSdkManager(defaultSdkDirectory.getAbsolutePath(), useSummaries,

+ defaultSdkCreator),

defaultSdk,

service,

serverPlugin,