Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: components/history/core/browser/history_service.cc

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sky's comments and some improvements to the code. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_service.cc
diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc
index 0c05e4f3ffa69d1c7172daf2becc9cc1483888d6..edf41992f01fcc51e2263e797d1b94d7fb2eb7a2 100644
--- a/components/history/core/browser/history_service.cc
+++ b/components/history/core/browser/history_service.cc
@@ -107,11 +107,12 @@ class HistoryService::BackendDelegate : public HistoryBackend::Delegate {
: history_service_(history_service),
service_task_runner_(service_task_runner) {}
- void NotifyProfileError(sql::InitStatus init_status) override {
+ void NotifyProfileError(sql::InitStatus init_status,
+ const std::string& diagnostics) override {
// Send to the history service on the main thread.
service_task_runner_->PostTask(
FROM_HERE, base::Bind(&HistoryService::NotifyProfileError,
- history_service_, init_status));
+ history_service_, init_status, diagnostics));
}
void SetInMemoryBackend(
@@ -966,10 +967,11 @@ void HistoryService::SetInMemoryBackend(
in_memory_backend_->AttachToHistoryService(this);
}
-void HistoryService::NotifyProfileError(sql::InitStatus init_status) {
+void HistoryService::NotifyProfileError(sql::InitStatus init_status,
+ const std::string& diagnostics) {
DCHECK(thread_checker_.CalledOnValidThread());
if (history_client_)
- history_client_->NotifyProfileError(init_status);
+ history_client_->NotifyProfileError(init_status, diagnostics);
}
void HistoryService::DeleteURL(const GURL& url) {

Powered by Google App Engine
This is Rietveld 408576698