Offer user to send feedback from profile error dialog

components/history/core/browser/history_database.cc

Index: components/history/core/browser/history_database.cc
diff --git a/components/history/core/browser/history_database.cc b/components/history/core/browser/history_database.cc
index a11edafc1465c8d448e3b7ae7075bb98527fee2d..a3efe5632c440f415f51f1072f7adbd8ba7aed35 100644
--- a/components/history/core/browser/history_database.cc
+++ b/components/history/core/browser/history_database.cc
@@ -56,9 +56,6 @@ HistoryDatabase::~HistoryDatabase() {
 sql::InitStatus HistoryDatabase::Init(const base::FilePath& history_name) {
   db_.set_histogram_tag("History");
 
-  // Set the exceptional sqlite error handler.
-  db_.set_error_callback(error_callback_);
-
   // Set the database page size to something a little larger to give us
   // better performance (we're typically seek rather than bandwidth limited).
   // This only has an effect before any tables have been created, otherwise
@@ -259,7 +256,8 @@ void HistoryDatabase::CommitTransaction() {
 }
 
 void HistoryDatabase::RollbackTransaction() {
-  db_.RollbackTransaction();
+  if (db_.transaction_nesting())

[sky, 2016/08/02 13:27:21]

Why are you doing this change now? Shouldn't this be a DCHECK?

[afakhry, 2016/08/02 23:58:24]

Exactly. It is a DCHECK that I'm trying to avoid.

[38832:38868:0802/112445:FATAL:connection.cc(1251)] Rolling back a nonexistent
transaction
#0 0x2b788240e86e base::debug::StackTrace::StackTrace()
#1 0x2b788246a23c logging::LogMessage::~LogMessage()
#2 0x2b7884dd4023 sql::Connection::RollbackTransaction()
#3 0x2b787d69f629 history::HistoryDatabase::RollbackTransaction()
#4 0x2b787d6700fc history::HistoryBackend::KillHistoryDatabase()
#5 0x2b787d66d1ee history::HistoryBackend::InitImpl()
#6 0x2b787d66ce00 history::HistoryBackend::Init()
#7 0x2b7879ccf1d6
_ZN4base8internal13FunctorTraitsIMN10extensions19ExecuteCodeFunctionEFvbRKSsEvE6InvokeIRK13scoped_refptrIS3_EJbS5_EEEvS7_OT_DpOT0_
#8 0x2b7879ccf10b
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN10extensions19ExecuteCodeFunctionEFvbRKSsEJRK13scoped_refptrIS5_EbS7_EEEvOT_DpOT0_
#9 0x2b787d62a494
_ZN4base8internal7InvokerINS0_9BindStateIMN7history14HistoryBackendEFvbRKNS3_21HistoryDatabaseParamsEEJ13scoped_refptrIS4_EbS5_EEEFvvEE7RunImplIRKS9_RKSt5tupleIJSB_bS5_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#10 0x2b787d62a0ec
_ZN4base8internal7InvokerINS0_9BindStateIMN7history14HistoryBackendEFvbRKNS3_21HistoryDatabaseParamsEEJ13scoped_refptrIS4_EbS5_EEEFvvEE3RunEPNS0_13BindStateBaseE
#11 0x2b78823f247e base::Callback<>::Run()
#12 0x2b788241416e base::debug::TaskAnnotator::RunTask()
#13 0x2b7882486c71 base::MessageLoop::RunTask()
#14 0x2b7882486ef4 base::MessageLoop::DeferOrRunPendingTask()
#15 0x2b78824871be base::MessageLoop::DoWork()
#16 0x2b788249bfc4 base::MessagePumpDefault::Run()
#17 0x2b78824866da base::MessageLoop::RunHandler()
#18 0x2b788251edb4 base::RunLoop::Run()
#19 0x2b78825b2bd1 base::Thread::Run()
#20 0x2b78825b2f0b base::Thread::ThreadMain()
#21 0x2b788259fdda base::(anonymous namespace)::ThreadFunc()
#22 0x2b7897917184 start_thread
#23 0x2b7897c2737d clone


Now why does that happen?
When the database fails on a catastrophic error and HistoryDatabase::Init()
returns on line 103 here:
https://cs.chromium.org/chromium/src/components/history/core/browser/history_...,
the Transaction created on line 83 will be destructed and rolled back.
Now in HistoryBackend::InitImpl() when we call KillHistoryDatabase():
https://cs.chromium.org/chromium/src/components/history/core/browser/history_...,
and try to rollback a non-existing transaction:
https://cs.chromium.org/chromium/src/components/history/core/browser/history_...,
Boom ... DCHECK.

[sky, 2016/08/03 15:19:30]

Got it. Please add a comment.

[afakhry, 2016/08/03 17:51:23]

Done.

+    db_.RollbackTransaction();
 }
 
 bool HistoryDatabase::RecreateAllTablesButURL() {
@@ -296,6 +294,11 @@ bool HistoryDatabase::Raze() {
   return db_.Raze();
 }
 
+std::string HistoryDatabase::GetDiagnosticInfo(int extended_error,
+                                               sql::Statement* statement) {
+  return db_.GetDiagnosticInfo(extended_error, statement);
+}
+
 bool HistoryDatabase::SetSegmentID(VisitID visit_id, SegmentID segment_id) {
   sql::Statement s(db_.GetCachedStatement(SQL_FROM_HERE,
       "UPDATE visits SET segment_id = ? WHERE id = ?"));