components/history/core/browser/typed_url_syncable_service_unittest.cc - Issue 2107493002: Offer user to send feedback from profile error dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/typed_url_syncable_service_unittest.cc

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sky's comments and some improvements to the code. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/history/core/browser/history_database.cc ('K') | « components/history/core/browser/history_service.cc ('k') | components/history/core/test/history_backend_db_base_test.cc » ('j') | components/webdata/common/web_database_backend.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/typed_url_syncable_service_unittest.cc

diff --git a/components/history/core/browser/typed_url_syncable_service_unittest.cc b/components/history/core/browser/typed_url_syncable_service_unittest.cc

index fbb4c686b086e5624fce67e9734c2858bee12360..a3db4f31c613119535bd6dac9eda3c49b5c5b169 100644

--- a/components/history/core/browser/typed_url_syncable_service_unittest.cc

+++ b/components/history/core/browser/typed_url_syncable_service_unittest.cc

@@ -151,7 +151,8 @@ class TestHistoryBackendDelegate : public HistoryBackend::Delegate {

public:

TestHistoryBackendDelegate() {}

- void NotifyProfileError(sql::InitStatus init_status) override {}

+ void NotifyProfileError(sql::InitStatus init_status,

+ const std::string& diagnostics) override {}

void SetInMemoryBackend(

std::unique_ptr<InMemoryHistoryBackend> backend) override{};

void NotifyFaviconsChanged(const std::set<GURL>& page_urls,