third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 2106843005: Use SaveSameObject for Notification.data as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 2106843005: Use SaveSameObject for Notification.data as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-action-vibrate

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.h ('k') | third_party/WebKit/Source/modules/notifications/Notification.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index 45a5271c50f13d01eb8e0702bb5aee28a678253f..a3822b1a31487dc203ac8e238433949a4bdfc57d 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -294,13 +294,10 @@ bool Notification::requireInteraction() const

ScriptValue Notification::data(ScriptState* scriptState)

{

- if (m_developerData.isEmpty()) {

- const WebVector<char>& serializedData = m_data.data;

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(serializedData.data(), serializedData.size());

- m_developerData = ScriptValue(scriptState, serializedValue->deserialize(scriptState->isolate()));

- }

+ const WebVector<char>& serializedData = m_data.data;

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(serializedData.data(), serializedData.size());

- return m_developerData;

+ return ScriptValue(scriptState, serializedValue->deserialize(scriptState->isolate()));

}

Vector<v8::Local<v8::Value>> Notification::actions(ScriptState* scriptState) const