third_party/WebKit/Source/modules/notifications/Notification.h - Issue 2106843005: Use SaveSameObject for Notification.data as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2106843005: Use SaveSameObject for Notification.data as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-action-vibrate

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index 39b3c184cdba8dec1fd48a8043e56ddc7d13d367..e078296f60b68f88897b364d3fff4abaaa05853d 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -141,9 +141,6 @@ private:

WebNotificationData m_data;

- // ScriptValue representations of the developer-associated data. Initialized lazily on first access.

- ScriptValue m_developerData;

// Notifications can either be bound to the page, which means they're identified by

// their delegate, or persistent, which means they're identified by a persistent Id

// given to us by the embedder. This influences how we close the notification.