third_party/WebKit/Source/modules/notifications/Notification.idl - Issue 2106843005: Use SaveSameObject for Notification.data as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.idl

Issue 2106843005: Use SaveSameObject for Notification.data as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-action-vibrate

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/notifications/Notification.idl

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.idl b/third_party/WebKit/Source/modules/notifications/Notification.idl

index 5340c28f402f464bb1112427b55847b166b4f2bb..606f80071b510444f19dc6fae36009d3024c98d6 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.idl

+++ b/third_party/WebKit/Source/modules/notifications/Notification.idl

@@ -73,7 +73,7 @@ enum NotificationPermission {

readonly attribute boolean renotify;

readonly attribute boolean silent;

readonly attribute boolean requireInteraction;

- [CallWith=ScriptState, SameObject] readonly attribute any data;

+ [CallWith=ScriptState, SameObject, SaveSameObject] readonly attribute any data;

[CallWith=ScriptState, SameObject, SaveSameObject] readonly attribute FrozenArray<NotificationAction> actions;

[MeasureAs=NotificationClosed] void close();

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | no next file » | no next file with comments »