[Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true.

[Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true.

This works around dump_syms not being able to process dSYMs produced by
dsymutil from Xcodes prior to version 7.

BUG=622406
R=mark@chromium.org,dpranke@chromium.org

Committed: https://crrev.com/68422c30c7bbb5ef0253e24103b09ebe858a569b
Cr-Commit-Position: refs/heads/master@{#402375}

[Mark Mentovai, 2016-06-27 23:43:47]

LGTM

I assume the red bots are irrelevant.

https://codereview.chromium.org/2106443003/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2106443003/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1494: # version 7 also produce debug data that is
incompatible with Breakpad
produces

[Dirk Pranke, 2016-06-27 23:44:57]

lgtm w/ one of the fixes suggested below.

https://codereview.chromium.org/2106443003/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2106443003/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1490: if (enable_dsyms) {
you need to import("//build/config/mac/symbols.gni") first.

Or, probably better, just get rid of mac/symbols.gni and move those two args
into compiler.gni since you end up having to include both of them regardless.

[Dirk Pranke, 2016-06-27 23:45:23]

On 2016/06/27 23:43:47, Mark Mentovai wrote:
> I assume the red bots are irrelevant.

bad assumption ;)

[Robert Sesek, 2016-06-27 23:45:59]

Patchset #2 (id:20001) has been deleted

[Robert Sesek, 2016-06-27 23:47:43]

I left the import commit on a different branch :). Fixed, as well as the typo.

[Robert Sesek, 2016-06-28 00:56:55]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-06-28 00:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2106443003/#ps60001
(title: "iOS")

[commit-bot: I haz the power, 2016-06-28 00:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 02:05:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-28 02:08:04]

Description was changed from

==========
[Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true.

This works around dump_syms not being able to process dSYMs produced by
dsymutil from Xcodes prior to version 7.

BUG=622406
R=mark@chromium.org,dpranke@chromium.org
==========

to

==========
[Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true.

This works around dump_syms not being able to process dSYMs produced by
dsymutil from Xcodes prior to version 7.

BUG=622406
R=mark@chromium.org,dpranke@chromium.org

Committed: https://crrev.com/68422c30c7bbb5ef0253e24103b09ebe858a569b
Cr-Commit-Position: refs/heads/master@{#402375}
==========

[commit-bot: I haz the power, 2016-06-28 02:08:05]

Patchset 3 (id:??) landed as
https://crrev.com/68422c30c7bbb5ef0253e24103b09ebe858a569b
Cr-Commit-Position: refs/heads/master@{#402375}