Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2106443003: [Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 4b624cfe3d107f35edc763d7bb22e54819e70f3b..6fa93d43814d289b0870092a838b323ce1a53461 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -18,6 +18,9 @@ if (current_cpu == "mipsel" || current_cpu == "mips64el") {
if (is_win) {
import("//build/config/win/visual_studio_version.gni")
}
+if (is_mac) {
+ import("//build/config/mac/symbols.gni")
+}
declare_args() {
# Default to warnings as errors for default workflow, where we catch
@@ -1487,6 +1490,14 @@ config("symbols") {
} else {
if (is_mac || is_ios) {
cflags = [ "-gdwarf-2" ]
+ if (is_mac && enable_dsyms) {
+ # If generating dSYMs, specify -fno-standalone-debug. This was
+ # originally specified for https://crbug.com/479841 because dsymutil
+ # could not handle a 4GB dSYM file. But dsymutil from Xcodes prior to
+ # version 7 also produces debug data that is incompatible with Breakpad
+ # dump_syms, so this is still required (https://crbug.com/622406).
+ cflags += [ "-fno-standalone-debug" ]
+ }
} else {
cflags = [ "-g2" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698