Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2106443003: [Mac/GN] Compile with -fno-standalone-debug if enable_dsyms=true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 # Tell VS 2015+ to create a PDB that references debug 1480 # Tell VS 2015+ to create a PDB that references debug
1481 # information in .obj and .lib files instead of copying 1481 # information in .obj and .lib files instead of copying
1482 # it all. This flag is incompatible with /PROFILE 1482 # it all. This flag is incompatible with /PROFILE
1483 ldflags = [ "/DEBUG:FASTLINK" ] 1483 ldflags = [ "/DEBUG:FASTLINK" ]
1484 } else { 1484 } else {
1485 ldflags = [ "/DEBUG" ] 1485 ldflags = [ "/DEBUG" ]
1486 } 1486 }
1487 } else { 1487 } else {
1488 if (is_mac || is_ios) { 1488 if (is_mac || is_ios) {
1489 cflags = [ "-gdwarf-2" ] 1489 cflags = [ "-gdwarf-2" ]
1490 if (enable_dsyms) {
Dirk Pranke 2016/06/27 23:44:57 you need to import("//build/config/mac/symbols.gni
1491 # If generating dSYMs, specify -fno-standalone-debug. This was
1492 # originally specified for https://crbug.com/479841 because dsymutil
1493 # could not handle a 4GB dSYM file. But dsymutil from Xcodes prior to
1494 # version 7 also produce debug data that is incompatible with Breakpad
Mark Mentovai 2016/06/27 23:43:46 produces
1495 # dump_syms, so this is still required (https://crbug.com/622406).
1496 cflags += [ "-fno-standalone-debug" ]
1497 }
1490 } else { 1498 } else {
1491 cflags = [ "-g2" ] 1499 cflags = [ "-g2" ]
1492 } 1500 }
1493 if (use_debug_fission) { 1501 if (use_debug_fission) {
1494 cflags += [ "-gsplit-dwarf" ] 1502 cflags += [ "-gsplit-dwarf" ]
1495 } 1503 }
1496 asmflags = cflags 1504 asmflags = cflags
1497 ldflags = [] 1505 ldflags = []
1498 } 1506 }
1499 } 1507 }
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 1552
1545 if (is_ios || is_mac) { 1553 if (is_ios || is_mac) {
1546 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1554 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1547 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1555 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1548 config("enable_arc") { 1556 config("enable_arc") {
1549 common_flags = [ "-fobjc-arc" ] 1557 common_flags = [ "-fobjc-arc" ]
1550 cflags_objc = common_flags 1558 cflags_objc = common_flags
1551 cflags_objcc = common_flags 1559 cflags_objcc = common_flags
1552 } 1560 }
1553 } 1561 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698