Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2106353005:
Make mffr.py work on Windows for tools/git/mass-rename.py (Closed)
DescriptionMake mffr.py work on Windows for tools/git/mass-rename.py
Previously it would confusingly just print
d:\src\cr3\src>python tools\git\mass-rename.py
The system cannot find the path specified.
and exit without doing anything.
NO_DEPENDENCY_CHECKS=true
R=thakis@chromium.org
Committed: https://crrev.com/4409723e40215782ed6e44d328b3f9bb7743ffe6
Cr-Commit-Position: refs/heads/master@{#410268}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 19 (11 generated)
Description was changed from ========== Make mffr.py work on Windows for tools/git/mass-rename.py R=thakis@chromium.org ========== to ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print [cpsp-rdhi-try-2]d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. R=thakis@chromium.org ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print [cpsp-rdhi-try-2]d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. R=thakis@chromium.org ========== to ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. R=thakis@chromium.org ==========
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Could you take a look at this when you have a moment?
Lgtm Sorry, missed this the first time apparently. Feel free to ping after a few hours of no reply.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. R=thakis@chromium.org ========== to ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org ==========
Message was sent while issue was closed.
Description was changed from ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org ========== to ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org ========== to ========== Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org Committed: https://crrev.com/4409723e40215782ed6e44d328b3f9bb7743ffe6 Cr-Commit-Position: refs/heads/master@{#410268} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4409723e40215782ed6e44d328b3f9bb7743ffe6 Cr-Commit-Position: refs/heads/master@{#410268} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
