Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2106353005: Make mffr.py work on Windows for tools/git/mass-rename.py (Closed)

Created:
4 years, 5 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make mffr.py work on Windows for tools/git/mass-rename.py Previously it would confusingly just print d:\src\cr3\src>python tools\git\mass-rename.py The system cannot find the path specified. and exit without doing anything. NO_DEPENDENCY_CHECKS=true R=thakis@chromium.org Committed: https://crrev.com/4409723e40215782ed6e44d328b3f9bb7743ffe6 Cr-Commit-Position: refs/heads/master@{#410268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M tools/git/mffr.py View 3 chunks +20 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
scottmg
4 years, 5 months ago (2016-06-30 20:41:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106353005/60001
4 years, 5 months ago (2016-06-30 22:13:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 23:09:11 UTC) #10
scottmg
Could you take a look at this when you have a moment?
4 years, 4 months ago (2016-08-06 00:00:47 UTC) #11
Nico
Lgtm Sorry, missed this the first time apparently. Feel free to ping after a few ...
4 years, 4 months ago (2016-08-06 00:56:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106353005/60001
4 years, 4 months ago (2016-08-06 17:37:07 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 4 months ago (2016-08-06 18:08:11 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 18:09:30 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4409723e40215782ed6e44d328b3f9bb7743ffe6
Cr-Commit-Position: refs/heads/master@{#410268}

Powered by Google App Engine
This is Rietveld 408576698