Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108053005: Pull ChildProcessSecurityPolicyImpl out to shared subfolder (Closed)

Created:
4 years, 5 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, toyoshim+midi_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, blink-worker-reviews_chromium.org, creis+watch_chromium.org, Randy Smith (Not in Mondays), nhiroki, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, jsbell+idb_chromium.org, michaeln, serviceworker-reviews, avayvod+watch_chromium.org, kinuko+serviceworker, pfeldman, cmumford, horo+watch_chromium.org, kinuko+fileapi, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull ChildProcessSecurityPolicyImpl out to shared subfolder The idea is to break up ChildProcessSecurityPolicyImpl into two pieces, one of which is for the browser only, and the other part which is shared between browser and loader. This is a first mechanical step to move to a separate folder, but doesn't actually fix anything yet. BUG=598073, 624183 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -1322 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/child_process_security_policy_impl.h View 1 chunk +0 lines, -259 lines 0 comments Download
D content/browser/child_process_security_policy_impl.cc View 1 chunk +0 lines, -867 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/dom_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/DEPS View 4 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/async_revalidation_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/midi_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_security_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A content/browser/shared/DEPS View 1 chunk +20 lines, -0 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_helper.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_helper.cc View 1 36 chunks +142 lines, -140 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2106353005 Patch 60001

Messages

Total messages: 3 (3 generated)
scottmg
Description was changed from ========== rdhi child process security try 2 BUG=598073,624183 ========== to ========== ...
4 years, 5 months ago (2016-06-30 22:13:21 UTC) #1
scottmg
Description was changed from ========== rdhi child process security try 2 BUG=598073,624183 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ...
4 years, 5 months ago (2016-06-30 22:33:01 UTC) #2
scottmg
4 years, 5 months ago (2016-06-30 22:39:47 UTC) #3 
Description was changed from

==========
Pull ChildProcessSecurityPolicyImpl out to shared subfolder

BUG=598073,624183
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pull ChildProcessSecurityPolicyImpl out to shared subfolder

The idea is to break up ChildProcessSecurityPolicyImpl into two pieces,
one of which is for the browser only, and the other part which is shared
between browser and loader. This is a first mechanical step to move to a
separate folder, but doesn't actually fix anything yet.

BUG=598073,624183
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698