Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2111343002: Move implementation of ChildProcessSecurityPolicyImpl to c/b/shared, and wrap in c/b (Closed)

Created:
4 years, 5 months ago by scottmg
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam, Randy Smith (Not in Mondays), mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@mffr-win
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move implementation of ChildProcessSecurityPolicyImpl to c/b/shared, and wrap in c/b I tried to do the refactor all-in-one but it got too complicated. So as a first step, move the implementation of ChildProcessSecurityPolicyImpl to c/b/shared as ChildProcessSecurityPolicyHelper, which implements the same interface and holds all data (but isn't directly an implementation of ChildProcessSecurityPolicy), and then have ChildProcessSecurityPolicyImpl forward to it. The idea for followups would be to pick apart the implementation hopefully removing parts the loader doesn't need. I'm not really sure how that'll work yet though. TODO c/b/shared is intended for code to be shared between browser and loader, needs a better name before landing. R=jam BUG=598073, 624183

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2386 lines, -3821 lines) Patch
D content/browser/child_process_security_policy_browsertest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M content/browser/child_process_security_policy_impl.h View 1 chunk +0 lines, -76 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 2 chunks +90 lines, -650 lines 0 comments Download
D content/browser/child_process_security_policy_unittest.cc View 1 chunk +0 lines, -736 lines 0 comments Download
M content/browser/loader/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
A content/browser/shared/DEPS View 1 chunk +32 lines, -0 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_browsertest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_helper.h View 7 chunks +44 lines, -58 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_helper.cc View 36 chunks +141 lines, -144 lines 0 comments Download
A + content/browser/shared/child_process_security_policy_unittest.cc View 26 chunks +118 lines, -140 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1939 lines, -1939 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111343002/20001
4 years, 5 months ago (2016-07-01 00:10:19 UTC) #2
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:07:59 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698