Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2105873005: Remove tools/android/heap_profiler (Closed)

Created:
4 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, DmitrySkiba
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove tools/android/heap_profiler It is a standalone .so library meant to be LD_PRELOAD-ed using awkward tricks into the Android zygote to get heap dumps. Never worked too well in Chrome as it intercepted only malloc calls, without being able to hook allocations in PartitionAlloc or Blink GC. This is subsumed by the work of crbug.com/602701 which integrates native heap profiling with chrome://tracing and supports all the major chrome allocators. For future heap profiling adventures use //components/tracing/docs/heap_profiler.md This CL also removes //third_party/bsdtrees that was introduced as a dependency to libheap_profiler. Nothing else seems to depend on it. BUG=382489 Committed: https://crrev.com/cf04606c3af6634f3bcbd8d39007e6061372a3c0 Cr-Commit-Position: refs/heads/master@{#403179}

Patch Set 1 #

Patch Set 2 : Remove heap_profiler_unittests from all targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2611 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/bsdtrees/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/bsdtrees/README.chromium View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/bsdtrees/tree.h View 1 chunk +0 lines, -748 lines 0 comments Download
M tools/android/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/android/android_tools.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/android/heap_profiler/BUILD.gn View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/android/heap_profiler/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/android/heap_profiler/heap_dump.c View 1 chunk +0 lines, -350 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler.h View 1 chunk +0 lines, -92 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler.c View 1 chunk +0 lines, -397 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler.gyp View 1 chunk +0 lines, -75 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler_hooks_android.c View 1 chunk +0 lines, -211 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler_integrationtest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D tools/android/heap_profiler/heap_profiler_unittest.cc View 1 chunk +0 lines, -458 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Primiano Tucci (use gerrit)
Nico, I have a very easy CL for you (all -- lines) Nuking some unused ...
4 years, 5 months ago (2016-06-30 08:10:09 UTC) #4
Nico
lgtm
4 years, 5 months ago (2016-06-30 10:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105873005/20001
4 years, 5 months ago (2016-06-30 14:07:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 15:14:06 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 15:14:12 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:15:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf04606c3af6634f3bcbd8d39007e6061372a3c0
Cr-Commit-Position: refs/heads/master@{#403179}

Powered by Google App Engine
This is Rietveld 408576698