Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2105853002: Merge to 2743 "[DevTools] Explicitly reset context group when clearing ScriptController." (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge to 2743 "[DevTools] Explicitly reset context group when clearing ScriptController." > [DevTools] Explicitly reset context group when clearing ScriptController. > > Previously, we assumed that main world context creation means reset. > This is not the case when content script is executed before main world script, > and we ended up with content script context being cleared from debugger. > Now we get explicit notification from ScriptController to reset (mainly on navigation). > > BUG=617530 > > Review-Url: https://codereview.chromium.org/2064133002 > Cr-Commit-Position: refs/heads/master@{#400770} (cherry picked from commit 151d5d907870e262ff7f94fd4b1f1e5ef887e96d) TBR=pfeldman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/87c1e7416fb66c6892abb38d9295c611e03e1157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M content/renderer/render_view_browsertest.cc View 7 chunks +53 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
4 years, 5 months ago (2016-06-28 17:24:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87c1e7416fb66c6892abb38d9295c611e03e1157.

Powered by Google App Engine
This is Rietveld 408576698