Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2064133002:
[DevTools] Explicitly reset context group when clearing ScriptController. (Closed)
|
Created:
4 years, 6 months ago by dgozman Modified:
4 years, 6 months ago Reviewers:
pfeldman CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, creis+watch_chromium.org, pfeldman+blink_chromium.org, nasko+codewatch_chromium.org, jam, tyoshino+watch_chromium.org, lushnikov+blink_chromium.org, blink-reviews, darin-cc_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, Nate Chapin, loading-reviews_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Explicitly reset context group when clearing ScriptController.
Previously, we assumed that main world context creation means reset.
This is not the case when content script is executed before main world script,
and we ended up with content script context being cleared from debugger.
Now we get explicit notification from ScriptController to reset (mainly on navigation).
BUG=617530
Committed: https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d
Cr-Commit-Position: refs/heads/master@{#400770}
Patch Set 1 #Patch Set 2 : updateDocument #Patch Set 3 : clear #
Messages
Total messages: 33 (16 generated)
dgozman@chromium.org changed reviewers: + pfeldman@chromium.org
Could you please take a look?
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
On 2016/06/14 14:39:25, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) This doesn't work in current state, I'll work on better approach.
Description was changed from ========== [DevTools] Explicitly reset context group on didClearDocumentOfWindowObject. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from FrameLoader before any context is created for the frame. BUG=617530 ========== to ========== [DevTools] Explicitly reset context group in updateDocument. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController before any context is created for the frame. BUG=617530 ==========
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/40001
Description was changed from ========== [DevTools] Explicitly reset context group in updateDocument. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController before any context is created for the frame. BUG=617530 ========== to ========== [DevTools] Explicitly reset context group when clearing ScriptController. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController to reset (mainly on navigation). BUG=617530 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ready for review. Please take a look.
lgtm
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064133002/40001
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Explicitly reset context group when clearing ScriptController. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController to reset (mainly on navigation). BUG=617530 ========== to ========== [DevTools] Explicitly reset context group when clearing ScriptController. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController to reset (mainly on navigation). BUG=617530 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Explicitly reset context group when clearing ScriptController. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController to reset (mainly on navigation). BUG=617530 ========== to ========== [DevTools] Explicitly reset context group when clearing ScriptController. Previously, we assumed that main world context creation means reset. This is not the case when content script is executed before main world script, and we ended up with content script context being cleared from debugger. Now we get explicit notification from ScriptController to reset (mainly on navigation). BUG=617530 Committed: https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d Cr-Commit-Position: refs/heads/master@{#400770} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/151d5d907870e262ff7f94fd4b1f1e5ef887e96d Cr-Commit-Position: refs/heads/master@{#400770} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
