Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2105853002: Merge to 2743 "[DevTools] Explicitly reset context group when clearing ScriptController." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index d318dd64d4739e303a95011f1114540a275ff7d1..4e3f025f9165ac695edcc05f530a2a9d47c55295 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -57,6 +57,7 @@
#include "core/inspector/ConsoleMessage.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/InspectorTraceEvents.h"
+#include "core/inspector/MainThreadDebugger.h"
#include "core/loader/DocumentLoader.h"
#include "core/loader/FrameLoader.h"
#include "core/loader/FrameLoaderClient.h"
@@ -99,6 +100,7 @@ DEFINE_TRACE(ScriptController)
void ScriptController::clearForClose()
{
m_windowProxyManager->clearForClose();
+ MainThreadDebugger::instance()->didClearContextsForFrame(frame());
}
void ScriptController::updateSecurityOrigin(SecurityOrigin* origin)
@@ -266,6 +268,7 @@ void ScriptController::clearWindowProxy()
// V8 binding expects ScriptController::clearWindowProxy only be called
// when a frame is loading a new page. This creates a new context for the new page.
m_windowProxyManager->clearForNavigation();
+ MainThreadDebugger::instance()->didClearContextsForFrame(frame());
}
void ScriptController::setCaptureCallStackForUncaughtExceptions(v8::Isolate* isolate, bool value)
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698