Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105833003: [MD settings] side nav ink ripple on click (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] side nav ink ripple on click This CL adds ripples to the side nav menu. BUG=609318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7f49d51950d728ecbdcbfc0d269ce0879e9732c0 Cr-Commit-Position: refs/heads/master@{#404189}

Patch Set 1 : cleanup #

Total comments: 6

Patch Set 2 : review changes #

Total comments: 6

Patch Set 3 : review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
dschuyler
4 years, 5 months ago (2016-06-28 22:57:09 UTC) #4
Dan Beam
https://codereview.chromium.org/2105833003/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/2105833003/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode62 chrome/browser/resources/settings/settings_menu/settings_menu.html:62: color: rgba(33, 150, 243, .5); /* Google-blue-500 at 50%. ...
4 years, 5 months ago (2016-06-28 23:59:43 UTC) #5
dschuyler
https://codereview.chromium.org/2105833003/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/2105833003/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode62 chrome/browser/resources/settings/settings_menu/settings_menu.html:62: color: rgba(33, 150, 243, .5); /* Google-blue-500 at 50%. ...
4 years, 5 months ago (2016-07-06 21:05:33 UTC) #6
michaelpg
sweet, lgtm https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js#newcode72 chrome/browser/resources/settings/settings_menu/settings_menu.js:72: Polymer.dom(target).removeChild(ripple); ripple.remove();
4 years, 5 months ago (2016-07-06 23:19:06 UTC) #7
Dan Beam
lgtm https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js#newcode72 chrome/browser/resources/settings/settings_menu/settings_menu.js:72: Polymer.dom(target).removeChild(ripple); On 2016/07/06 23:19:06, michaelpg wrote: > ripple.remove(); ...
4 years, 5 months ago (2016-07-06 23:24:26 UTC) #9
dschuyler
https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2105833003/diff/40001/chrome/browser/resources/settings/settings_menu/settings_menu.js#newcode72 chrome/browser/resources/settings/settings_menu/settings_menu.js:72: Polymer.dom(target).removeChild(ripple); On 2016/07/06 23:19:06, michaelpg wrote: > ripple.remove(); Done. ...
4 years, 5 months ago (2016-07-07 01:36:10 UTC) #10
Dan Beam
still lgtm
4 years, 5 months ago (2016-07-07 18:13:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105833003/60001
4 years, 5 months ago (2016-07-07 18:20:00 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-07 18:42:48 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 18:42:50 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:44:31 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7f49d51950d728ecbdcbfc0d269ce0879e9732c0
Cr-Commit-Position: refs/heads/master@{#404189}

Powered by Google App Engine
This is Rietveld 408576698