chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 2105833003: [MD settings] side nav ink ripple on click

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2105833003: [MD settings] side nav ink ripple on click (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index a0eb44a33889440c0ab7811fbf3ccb3a21c17c1f..adad5296b9ad1529e97ade0228639ab57e46579f 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -3,6 +3,7 @@

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripple.html">

@@ -53,6 +54,15 @@

};

}

+ paper-menu div {

+ position: relative; /* Needed for paper-ripple. */

+ }

+ paper-ripple {

+ color: var(--google-blue-500);

+ opacity: .5;

+ }

.page-menu paper-menu {

--paper-menu-selected-item: {

color: var(--google-blue-500);