Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2105833003: [MD settings] side nav ink ripple on click (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index d2a4c90547977df353e16b76a8f876d4c5389822..016b1a81140829ce6b6a0cd3d660808b7fcb5cf0 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -63,10 +63,25 @@ Polymer({
},
/**
+ * @param {!Node} target
+ * @private
+ */
+ ripple_: function(target) {
+ var ripple = document.createElement('paper-ripple');
+ ripple.addEventListener('transitionend', function() {
+ ripple.remove();
+ });
+ target.appendChild(ripple);
+ ripple.downAction();
+ ripple.upAction();
+ },
+
+ /**
* @param {!Event} event
* @private
*/
openPage_: function(event) {
+ this.ripple_(/** @type {!Node} */(event.currentTarget));
var submenuRoute = event.currentTarget.parentNode.dataset.page;
if (submenuRoute) {
this.currentRoute = {
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698