Issue 2105683006: Remove DoubleRepresentation from globals.h

Issue 2105683006: Remove DoubleRepresentation from globals.h (Closed)

Created:
4 years, 5 months ago by ahaas

Modified:
4 years, 5 months ago

Reviewers:
titzer

CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove DoubleRepresentation from globals.h The implementation of DoubleRepresentation was based on undefined behavior, and it can be replaced by bit_casts. BUG=chromium:623168 R=titzer@chromium.org Committed: https://crrev.com/db0811fe5f1cd6f0f4fedc8ca282e33dd2c6de24 Cr-Commit-Position: refs/heads/master@{#37390}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -32 lines)			Patch
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/conversions.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/mips64/macro-assembler-mips64.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 11 (4 generated)

titzer

On 2016/06/29 09:37:35, ahaas wrote: lgtm, nice simplification!

4 years, 5 months ago (2016-06-29 09:40:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105683006/1

4 years, 5 months ago (2016-06-29 09:40:44 UTC) #4

commit-bot: I haz the power

Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

4 years, 5 months ago (2016-06-29 11:44:41 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105683006/1

4 years, 5 months ago (2016-06-29 11:53:40 UTC) #8

commit-bot: I haz the power

4 years, 5 months ago (2016-06-29 12:01:19 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/db0811fe5f1cd6f0f4fedc8ca282e33dd2c6de24
Cr-Commit-Position: refs/heads/master@{#37390}