src/conversions.h - Issue 2105683006: Remove DoubleRepresentation from globals.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions.h

Issue 2105683006: Remove DoubleRepresentation from globals.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/conversions.h

diff --git a/src/conversions.h b/src/conversions.h

index 29262e53063ac5c6a74383dd12f5c19561b0c01a..c4838f2d21e462d475f0f2f98c16f61200038630 100644

--- a/src/conversions.h

+++ b/src/conversions.h

@@ -149,8 +149,7 @@ char* DoubleToRadixCString(double value, int radix);

static inline bool IsMinusZero(double value) {

- static const DoubleRepresentation minus_zero(-0.0);

- return DoubleRepresentation(value) == minus_zero;

+ return bit_cast<int64_t>(value) == bit_cast<int64_t>(-0.0);

}

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/factory.cc » ('j') | no next file with comments »