content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_types.h ('K') | « content/public/renderer/resource_fetcher.h ('k') | content/renderer/fetchers/resource_fetcher_impl.h » ('j') | third_party/WebKit/Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

diff --git a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

index d97dbe23377d524b06a83a99f1fddb73c88604e2..1eea2aafb99bef6555d0c2523da7beacf72a7aea 100644

--- a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

+++ b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

@@ -44,7 +44,7 @@ MultiResolutionImageResourceFetcher::MultiResolutionImageResourceFetcher(

// workers. This should ideally not happen or at least not all the time.

// See https://crbug.com/448427

if (request_context == WebURLRequest::RequestContextFavicon)

- fetcher_->SetSkipServiceWorker(true);

+ fetcher_->SetSkipServiceWorker(WebURLRequest::SkipServiceWorker::All);

fetcher_->SetCachePolicy(cache_policy);