Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105473002: Rename visualViewport.pageScale to visualViewport.scale (Closed)

Created:
4 years, 5 months ago by ymalik
Modified:
4 years, 5 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename visualViewport.pageScale to visualViewport.scale https://github.com/WICG/ViewportAPI/issues/8 BUG=595826 Committed: https://crrev.com/c3d5388c0c298a1811b70b8d56c223aebc8d1d39 Cr-Commit-Position: refs/heads/master@{#402410}

Patch Set 1 #

Patch Set 2 : update global-interface-listing test #

Patch Set 3 : fix broken tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -90 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html View 2 chunks +45 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ymalik
4 years, 5 months ago (2016-06-27 21:28:30 UTC) #3
bokan
lgtm
4 years, 5 months ago (2016-06-27 21:31:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105473002/40001
4 years, 5 months ago (2016-06-28 04:24:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-28 05:43:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 05:44:53 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c3d5388c0c298a1811b70b8d56c223aebc8d1d39
Cr-Commit-Position: refs/heads/master@{#402410}

Powered by Google App Engine
This is Rietveld 408576698