Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2104913002: Rename threadSafeBind() to crossThreadBind() (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
kinuko, haraken, sof, tzik
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, blink-reviews-wtf_chromium.org, rwlbuis, caseq+blink_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, ajuma+watch_chromium.org, blink-worker-reviews_chromium.org, Mads Ager (chromium), sof, jbroman, lushnikov+blink_chromium.org, Raymond Toy, loading-reviews_chromium.org, krit, Nate Chapin, danakj+watch_chromium.org, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, falken, pfeldman+blink_chromium.org, f(malita), oilpan-reviews, horo+watch_chromium.org, Stephen Chennney, Mikhail, kouhei+heap_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@TRV_CTCPointer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename threadSafeBind() to crossThreadBind() BUG=597856 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/f92842facb2524fba2e27126ed83044262fdcad2 Cr-Commit-Position: refs/heads/master@{#403069}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -225 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTask.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MainThreadTaskRunner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 10 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp View 12 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/CrossThreadFunctional.h View 4 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/platform/ThreadSafeFunctional.h View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobRegistry.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GCTaskRunner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorMutatorImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/SpinLockTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (20 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/1
4 years, 5 months ago (2016-06-28 12:39:39 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/27861) ios-simulator-gn on ...
4 years, 5 months ago (2016-06-28 12:42:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/20001
4 years, 5 months ago (2016-06-29 05:40:36 UTC) #7
hiroshige
PTAL.
4 years, 5 months ago (2016-06-29 05:44:30 UTC) #10
haraken
LGTM
4 years, 5 months ago (2016-06-29 05:56:14 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1852)
4 years, 5 months ago (2016-06-29 06:23:55 UTC) #13
tzik
lgtm
4 years, 5 months ago (2016-06-29 06:35:29 UTC) #14
sof
lgtm
4 years, 5 months ago (2016-06-29 06:43:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/20001
4 years, 5 months ago (2016-06-29 06:59:14 UTC) #18
Rik
??Hi, I'm currently on sabbatical unitl August 15. For urgent matters, please contact my manager ...
4 years, 5 months ago (2016-06-29 06:59:21 UTC) #19
kinuko
just adding one more lgtm
4 years, 5 months ago (2016-06-29 07:10:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1857)
4 years, 5 months ago (2016-06-29 07:34:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/20001
4 years, 5 months ago (2016-06-29 15:35:54 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1875)
4 years, 5 months ago (2016-06-29 16:10:04 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/20001
4 years, 5 months ago (2016-06-29 18:41:22 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/209657)
4 years, 5 months ago (2016-06-29 18:53:38 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/40001
4 years, 5 months ago (2016-06-29 18:56:44 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/96031) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 19:43:33 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104913002/40001
4 years, 5 months ago (2016-06-30 00:35:29 UTC) #37
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 02:20:22 UTC) #39
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 02:23:23 UTC) #41
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f92842facb2524fba2e27126ed83044262fdcad2
Cr-Commit-Position: refs/heads/master@{#403069}

Powered by Google App Engine
This is Rietveld 408576698