Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp

Issue 2104913002: Rename threadSafeBind() to crossThreadBind() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TRV_CTCPointer
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of 13 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
14 * its contributors may be used to endorse or promote products derived 14 * its contributors may be used to endorse or promote products derived
15 * from this software without specific prior written permission. 15 * from this software without specific prior written permission.
16 * 16 *
17 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 17 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
18 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 18 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
19 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 19 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
20 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 20 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
21 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 21 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "platform/audio/HRTFDatabaseLoader.h"
30
31 #include "platform/CrossThreadFunctional.h"
29 #include "platform/TaskSynchronizer.h" 32 #include "platform/TaskSynchronizer.h"
30 #include "platform/ThreadSafeFunctional.h"
31 #include "platform/audio/HRTFDatabaseLoader.h"
32 #include "public/platform/Platform.h" 33 #include "public/platform/Platform.h"
33 #include "public/platform/WebTaskRunner.h" 34 #include "public/platform/WebTaskRunner.h"
34 #include "public/platform/WebTraceLocation.h" 35 #include "public/platform/WebTraceLocation.h"
35 #include "wtf/PtrUtil.h" 36 #include "wtf/PtrUtil.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 using LoaderMap = HashMap<double, HRTFDatabaseLoader*>; 40 using LoaderMap = HashMap<double, HRTFDatabaseLoader*>;
40 41
41 static LoaderMap& loaderMap() 42 static LoaderMap& loaderMap()
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 89
89 void HRTFDatabaseLoader::loadAsynchronously() 90 void HRTFDatabaseLoader::loadAsynchronously()
90 { 91 {
91 ASSERT(isMainThread()); 92 ASSERT(isMainThread());
92 93
93 MutexLocker locker(m_lock); 94 MutexLocker locker(m_lock);
94 if (!m_hrtfDatabase && !m_thread) { 95 if (!m_hrtfDatabase && !m_thread) {
95 // Start the asynchronous database loading process. 96 // Start the asynchronous database loading process.
96 m_thread = wrapUnique(Platform::current()->createThread("HRTF database l oader")); 97 m_thread = wrapUnique(Platform::current()->createThread("HRTF database l oader"));
97 // TODO(alexclarke): Should this be posted as a loading task? 98 // TODO(alexclarke): Should this be posted as a loading task?
98 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(& HRTFDatabaseLoader::loadTask, crossThreadUnretained(this))); 99 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind( &HRTFDatabaseLoader::loadTask, crossThreadUnretained(this)));
99 } 100 }
100 } 101 }
101 102
102 bool HRTFDatabaseLoader::isLoaded() 103 bool HRTFDatabaseLoader::isLoaded()
103 { 104 {
104 MutexLocker locker(m_lock); 105 MutexLocker locker(m_lock);
105 return m_hrtfDatabase.get(); 106 return m_hrtfDatabase.get();
106 } 107 }
107 108
108 // This cleanup task is needed just to make sure that the loader thread finishes 109 // This cleanup task is needed just to make sure that the loader thread finishes
109 // the load task and thus the loader thread doesn't touch m_thread any more. 110 // the load task and thus the loader thread doesn't touch m_thread any more.
110 void HRTFDatabaseLoader::cleanupTask(TaskSynchronizer* sync) 111 void HRTFDatabaseLoader::cleanupTask(TaskSynchronizer* sync)
111 { 112 {
112 sync->taskCompleted(); 113 sync->taskCompleted();
113 } 114 }
114 115
115 void HRTFDatabaseLoader::waitForLoaderThreadCompletion() 116 void HRTFDatabaseLoader::waitForLoaderThreadCompletion()
116 { 117 {
117 if (!m_thread) 118 if (!m_thread)
118 return; 119 return;
119 120
120 TaskSynchronizer sync; 121 TaskSynchronizer sync;
121 // TODO(alexclarke): Should this be posted as a loading task? 122 // TODO(alexclarke): Should this be posted as a loading task?
122 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&HRTF DatabaseLoader::cleanupTask, crossThreadUnretained(this), crossThreadUnretained( &sync))); 123 m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&HRT FDatabaseLoader::cleanupTask, crossThreadUnretained(this), crossThreadUnretained (&sync)));
123 sync.waitForTaskCompletion(); 124 sync.waitForTaskCompletion();
124 m_thread.reset(); 125 m_thread.reset();
125 } 126 }
126 127
127 } // namespace blink 128 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698