Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/core/dom/CrossThreadTask.h

Issue 2104913002: Rename threadSafeBind() to crossThreadBind() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TRV_CTCPointer
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009-2010 Google Inc. All rights reserved. 2 * Copyright (C) 2009-2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef CrossThreadTask_h 31 #ifndef CrossThreadTask_h
32 #define CrossThreadTask_h 32 #define CrossThreadTask_h
33 33
34 #include "core/dom/ExecutionContext.h" 34 #include "core/dom/ExecutionContext.h"
35 #include "core/dom/ExecutionContextTask.h" 35 #include "core/dom/ExecutionContextTask.h"
36 #include "platform/ThreadSafeFunctional.h" 36 #include "platform/CrossThreadFunctional.h"
37 #include <type_traits> 37 #include <type_traits>
38 38
39 namespace blink { 39 namespace blink {
40 40
41 // createCrossThreadTask(...) is ExecutionContextTask version of 41 // createCrossThreadTask(...) is ExecutionContextTask version of
42 // threadSafeBind(). 42 // crossThreadBind().
43 // Using WTF::bind() directly is not thread-safe due to temporary objects, see 43 // Using WTF::bind() directly is not thread-safe due to temporary objects, see
44 // https://crbug.com/390851 for details. 44 // https://crbug.com/390851 for details.
45 // 45 //
46 // Example: 46 // Example:
47 // void func1(int, const String&); 47 // void func1(int, const String&);
48 // createCrossThreadTask(func1, 42, str); 48 // createCrossThreadTask(func1, 42, str);
49 // func1(42, str2) will be called, where |str2| is a deep copy of 49 // func1(42, str2) will be called, where |str2| is a deep copy of
50 // |str| (created by str.isolatedCopy()). 50 // |str| (created by str.isolatedCopy()).
51 // 51 //
52 // Don't (if you pass the task across threads): 52 // Don't (if you pass the task across threads):
(...skipping 15 matching lines...) Expand all
68 // (|ptr| can also be WeakPtr<C> or other pointer-like types) 68 // (|ptr| can also be WeakPtr<C> or other pointer-like types)
69 // and then the following are called on the target thread: 69 // and then the following are called on the target thread:
70 // functionEC(p1, ..., pn, context); 70 // functionEC(p1, ..., pn, context);
71 // ptr->memberEC(p1, ..., pn, context); 71 // ptr->memberEC(p1, ..., pn, context);
72 // function(p1, ..., pn); 72 // function(p1, ..., pn);
73 // ptr->member(p1, ..., pn); 73 // ptr->member(p1, ..., pn);
74 // 74 //
75 // ExecutionContext: 75 // ExecutionContext:
76 // |context| is supplied by the target thread. 76 // |context| is supplied by the target thread.
77 // 77 //
78 // Deep copies by threadSafeBind(): 78 // Deep copies by crossThreadBind():
79 // |ptr|, |p1|, ..., |pn| are processed by threadSafeBind() and thus 79 // |ptr|, |p1|, ..., |pn| are processed by crossThreadBind() and thus
80 // CrossThreadCopier. 80 // CrossThreadCopier.
81 // You don't have to call manually e.g. isolatedCopy(). 81 // You don't have to call manually e.g. isolatedCopy().
82 // To pass things that cannot be copied by CrossThreadCopier 82 // To pass things that cannot be copied by CrossThreadCopier
83 // (e.g. pointers), use crossThreadUnretained() explicitly. 83 // (e.g. pointers), use crossThreadUnretained() explicitly.
84 84
85 template<typename FunctionType, typename... P> 85 template<typename FunctionType, typename... P>
86 std::unique_ptr<ExecutionContextTask> createCrossThreadTask(FunctionType functio n, P&&... parameters) 86 std::unique_ptr<ExecutionContextTask> createCrossThreadTask(FunctionType functio n, P&&... parameters)
87 { 87 {
88 return internal::createCallClosureTask(threadSafeBind(function, std::forward <P>(parameters)...)); 88 return internal::createCallClosureTask(crossThreadBind(function, std::forwar d<P>(parameters)...));
89 } 89 }
90 90
91 } // namespace blink 91 } // namespace blink
92 92
93 #endif // CrossThreadTask_h 93 #endif // CrossThreadTask_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/CompositorProxy.cpp ('k') | third_party/WebKit/Source/core/dom/MainThreadTaskRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698