Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2104763002: Fix MSAN error on arm64 bot. (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix MSAN error on arm64 bot. The main fix is to mark stack memory the SafeStackFrameIterator accesses as initialied. Drive-by: Make sure we bail out when the simulator is in the process of updating FP/SP registers. BUG=v8:5156 Committed: https://crrev.com/ca1dcc9c03f6dc2397c1368aadd59d0aa97a3eff Cr-Commit-Position: refs/heads/master@{#37315}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove ifdef around MSAN macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M src/api.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/frames.cc View 1 4 chunks +2 lines, -7 lines 0 comments Download
M src/log.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/profiler/tick-sample.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104763002/1
4 years, 5 months ago (2016-06-28 01:44:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 02:08:24 UTC) #4
alph
4 years, 5 months ago (2016-06-28 06:10:54 UTC) #6
Yang
LGTM. Thanks! https://codereview.chromium.org/2104763002/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/2104763002/diff/1/src/frames.cc#newcode307 src/frames.cc:307: #if defined(USE_SIMULATOR) I think we can use ...
4 years, 5 months ago (2016-06-28 06:20:18 UTC) #7
alph
https://codereview.chromium.org/2104763002/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/2104763002/diff/1/src/frames.cc#newcode307 src/frames.cc:307: #if defined(USE_SIMULATOR) On 2016/06/28 06:20:18, Yang wrote: > I ...
4 years, 5 months ago (2016-06-28 07:27:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104763002/20001
4 years, 5 months ago (2016-06-28 07:27:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 07:57:28 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 07:58:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca1dcc9c03f6dc2397c1368aadd59d0aa97a3eff
Cr-Commit-Position: refs/heads/master@{#37315}

Powered by Google App Engine
This is Rietveld 408576698