Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: src/api.cc

Issue 2104763002: Fix MSAN error on arm64 bot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove ifdef around MSAN macro Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 79eb6198ca3f37cde9a0ee0121b56f4fabde7a99..296dc3bb37fe44264679e73df04a93cf2512e842 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7550,7 +7550,12 @@ void Isolate::GetStackSample(const RegisterState& state, void** frames,
regs.pc = state.pc;
regs.sp = state.sp;
regs.fp = state.fp;
- i::SimulatorHelper::FillRegisters(isolate, &regs);
+ if (!i::SimulatorHelper::FillRegisters(isolate, &regs)) {
+ sample_info->frames_count = 0;
+ sample_info->vm_state = OTHER;
+ sample_info->external_callback_entry = nullptr;
+ return;
+ }
#else
const RegisterState& regs = state;
#endif
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698