Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/profiler/tick-sample.cc

Issue 2104763002: Fix MSAN error on arm64 bot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove ifdef around MSAN macro Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/tick-sample.cc
diff --git a/src/profiler/tick-sample.cc b/src/profiler/tick-sample.cc
index 4b481325fa64734fa818b85b158f44ee6a123cd4..2595404c13a08070208ec2be8b8c024ba1436b1a 100644
--- a/src/profiler/tick-sample.cc
+++ b/src/profiler/tick-sample.cc
@@ -125,7 +125,8 @@ bool TickSample::GetStackSample(Isolate* isolate, const v8::RegisterState& regs,
if (sample_info->vm_state == GC) return true;
Address js_entry_sp = isolate->js_entry_sp();
- if (js_entry_sp == 0) return true; // Not executing JS now.
+ if (js_entry_sp == nullptr) return true; // Not executing JS now.
+ DCHECK(regs.sp);
if (regs.pc && IsNoFrameRegion(static_cast<Address>(regs.pc))) {
// Can't collect stack.
« no previous file with comments | « src/log.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698