Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds note about interim offliner status codes and performs DCHECK that offliner does not return the… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
index d7f28d9f43fad5fff6b6f6b5370fd9f0b6cf2b01..f662f12306903d6d9095d19b77ba942f732af2f0 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
@@ -223,7 +223,8 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromPrerenderStopLoading) {
PumpLoop();
EXPECT_TRUE(loader()->IsIdle());
EXPECT_FALSE(loader()->IsLoaded());
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
+ callback_load_status());
}
TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {
@@ -243,7 +244,8 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {
EXPECT_TRUE(loader()->IsIdle());
EXPECT_TRUE(callback_called());
// We did not provide any WebContents for the callback so expect did not load.
- EXPECT_EQ(Offliner::RequestStatus::FAILED, callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED,
+ callback_load_status());
// Stopped event causes no harm.
test_adapter()->GetObserver()->OnPrerenderStop();
@@ -262,8 +264,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadCanceledFromStopLoading) {
loader()->StopLoading();
PumpLoop();
EXPECT_TRUE(loader()->IsIdle());
- EXPECT_TRUE(callback_called());
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, callback_load_status());
+ EXPECT_FALSE(callback_called());
}
TEST_F(PrerenderingLoaderTest, LoadPageNotAcceptedWhenNotIdle) {

Powered by Google App Engine
This is Rietveld 408576698