Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds note about interim offliner status codes and performs DCHECK that offliner does not return the… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index b82a149ab9ddb0be4d9b23bb4c051f37614d5029..6f454028d33ae1ed2e3157747b55aca825368e9b 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -164,8 +164,8 @@ void PrerenderingLoader::HandleLoadingStopped() {
// Request status depends on whether we are still loading (failed) or
// did load and then loading was stopped (cancel - from prerender stack).
Offliner::RequestStatus request_status =
- IsLoaded() ? Offliner::RequestStatus::CANCELED
- : Offliner::RequestStatus::FAILED;
+ IsLoaded() ? Offliner::RequestStatus::PRERENDERING_CANCELED
+ : Offliner::RequestStatus::PRERENDERING_FAILED;
// TODO(dougarnett): For failure, determine from final status if retry-able
// and report different failure statuses if retry-able or not.
snapshot_controller_.reset(nullptr);
@@ -181,11 +181,6 @@ void PrerenderingLoader::CancelPrerender() {
}
snapshot_controller_.reset(nullptr);
session_contents_.reset(nullptr);
- if (!IsLoaded() && !IsIdle()) {
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(callback_, Offliner::RequestStatus::CANCELED, nullptr));
- }
state_ = State::IDLE;
}
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698