chrome/browser/android/offline_pages/prerendering_offliner.cc - Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds note about interim offliner status codes and performs DCHECK that offliner does not return the… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_loader_unittest.cc ('k') | chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc

index bab7d7fa6630b0794ed865cdf39d5ae6b0a2ed02..cf8625f981e0317f05337ac6c03c83c4addc7a84 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc

@@ -97,7 +97,7 @@ void PrerenderingOffliner::OnSavePageDone(

} else {

// TODO(dougarnett): Consider reflecting some recommendation to retry the

// request based on specific save error cases.

- save_status = RequestStatus::FAILED_SAVE;

+ save_status = RequestStatus::SAVE_FAILED;

}

completion_callback.Run(request, save_status);

}