Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104333003: Split mojo/public/cpp/system/tests/core_unittest.cc, part 2 (of 2, apparently). (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work794_wait_many_no_handles
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Split mojo/public/cpp/system/tests/core_unittest.cc, part 2 (of 2, apparently). R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9b788ca646976231c59d15ab96fa268e72e54b5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -450 lines) Patch
M mojo/nacl/BUILD.gn View 1 chunk +7 lines, -8 lines 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
A mojo/public/cpp/system/tests/buffer_unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download
D mojo/public/cpp/system/tests/core_unittest.cc View 1 chunk +0 lines, -441 lines 1 comment Download
M mojo/public/cpp/system/tests/handle_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A mojo/public/cpp/system/tests/message_pipe_unittest.cc View 1 chunk +297 lines, -0 lines 0 comments Download
A mojo/public/cpp/system/tests/wait_unittest.cc View 1 chunk +101 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2110103002 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
https://codereview.chromium.org/2104333003/diff/1/mojo/public/cpp/system/tests/core_unittest.cc File mojo/public/cpp/system/tests/core_unittest.cc (left): https://codereview.chromium.org/2104333003/diff/1/mojo/public/cpp/system/tests/core_unittest.cc#oldcode44 mojo/public/cpp/system/tests/core_unittest.cc:44: // Make sure that our specialized template correctly handles ...
4 years, 5 months ago (2016-06-29 17:56:21 UTC) #1
azani
lgtm
4 years, 5 months ago (2016-06-29 21:51:44 UTC) #2
viettrungluu
4 years, 5 months ago (2016-06-29 23:41:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b9b788ca646976231c59d15ab96fa268e72e54b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698