Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2110103002: Make MojoWaitMany() accept zero handles. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make MojoWaitMany() accept zero handles. This allows it to be used as a sleep function. It also makes it more consistent with the wait set API. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a7661ce75259db28c71940fb30a1e7f1550dac58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -37 lines) Patch
M mojo/edk/system/core.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 3 chunks +76 lines, -30 lines 0 comments Download
M mojo/public/c/system/tests/wait_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/public/c/system/wait.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/js/core_unittests.js View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-29 16:22:59 UTC) #1
azani
lgtm
4 years, 5 months ago (2016-06-29 16:57:04 UTC) #2
viettrungluu
4 years, 5 months ago (2016-06-29 17:56:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7661ce75259db28c71940fb30a1e7f1550dac58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698