Split mojo/public/cpp/system/tests/core_unittest.cc, part 2 (of 2, apparently).

mojo/public/cpp/system/tests/message_pipe_unittest.cc

Index: mojo/public/cpp/system/tests/message_pipe_unittest.cc
diff --git a/mojo/public/cpp/system/tests/message_pipe_unittest.cc b/mojo/public/cpp/system/tests/message_pipe_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..90c0d33158ab1e23205add15577af552dfc1e0a1
--- /dev/null
+++ b/mojo/public/cpp/system/tests/message_pipe_unittest.cc
@@ -0,0 +1,297 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file tests the C++ wrappers in mojo/public/cpp/system/message_pipe.h.
+
+#include "mojo/public/cpp/system/message_pipe.h"
+
+#include <vector>
+
+#include "mojo/public/cpp/system/handle.h"
+#include "mojo/public/cpp/system/wait.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace mojo {
+namespace {
+
+TEST(MessagePipeTest, InvalidArgs) {
+  MessagePipeHandle h_invalid;
+  EXPECT_FALSE(h_invalid.is_valid());
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+            WriteMessageRaw(h_invalid, nullptr, 0, nullptr, 0,
+                            MOJO_WRITE_MESSAGE_FLAG_NONE));
+  char buffer[10] = {0};
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+            WriteMessageRaw(h_invalid, buffer, sizeof(buffer), nullptr, 0,
+                            MOJO_WRITE_MESSAGE_FLAG_NONE));
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+            ReadMessageRaw(h_invalid, nullptr, nullptr, nullptr, nullptr,
+                           MOJO_READ_MESSAGE_FLAG_NONE));
+  uint32_t buffer_size = static_cast<uint32_t>(sizeof(buffer));
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+            ReadMessageRaw(h_invalid, buffer, &buffer_size, nullptr, nullptr,
+                           MOJO_READ_MESSAGE_FLAG_NONE));
+}
+
+TEST(MessagePipeTest, BasicWaitingAndClosing) {
+  // Cursory compilation test of |MakeScopedHandle()| with message pipe handles.
+  EXPECT_FALSE(MakeScopedHandle(MessagePipeHandle()).is_valid());
+
+  MojoHandle hv0 = kInvalidHandleValue;
+  {
+    ScopedMessagePipeHandle h0;
+    ScopedMessagePipeHandle h1;
+    EXPECT_FALSE(h0.get().is_valid());
+    EXPECT_FALSE(h1.get().is_valid());
+
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h0, &h1));
+    EXPECT_TRUE(h0.get().is_valid());
+    EXPECT_TRUE(h1.get().is_valid());
+    EXPECT_NE(h0.get().value(), h1.get().value());
+    // Save the handle values, so we can check that things got closed
+    // correctly.
+    hv0 = h0.get().value();
+    MojoHandle hv1 = h1.get().value();
+    MojoHandleSignalsState state;
+
+    EXPECT_EQ(MOJO_RESULT_DEADLINE_EXCEEDED,
+              Wait(h0.get(), MOJO_HANDLE_SIGNAL_READABLE, 0, &state));
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_WRITABLE, state.satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              state.satisfiable_signals);
+
+    std::vector<Handle> wh;
+    wh.push_back(h0.get());
+    wh.push_back(h1.get());
+    std::vector<MojoHandleSignals> sigs;
+    sigs.push_back(MOJO_HANDLE_SIGNAL_READABLE);
+    sigs.push_back(MOJO_HANDLE_SIGNAL_WRITABLE);
+    std::vector<MojoHandleSignalsState> states(sigs.size());
+    WaitManyResult wait_many_result = WaitMany(wh, sigs, 1000, &states);
+    EXPECT_EQ(MOJO_RESULT_OK, wait_many_result.result);
+    EXPECT_EQ(1u, wait_many_result.index);
+    EXPECT_TRUE(wait_many_result.IsIndexValid());
+    EXPECT_TRUE(wait_many_result.AreSignalsStatesValid());
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_WRITABLE, states[0].satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              states[0].satisfiable_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_WRITABLE, states[1].satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              states[1].satisfiable_signals);
+
+    // Test closing |h1| explicitly.
+    Close(h1.Pass());
+    EXPECT_FALSE(h1.get().is_valid());
+
+    // Make sure |h1| is closed.
+    EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+              Wait(Handle(hv1), ~MOJO_HANDLE_SIGNAL_NONE,
+                   MOJO_DEADLINE_INDEFINITE, nullptr));
+
+    EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
+              Wait(h0.get(), MOJO_HANDLE_SIGNAL_READABLE,
+                   MOJO_DEADLINE_INDEFINITE, &state));
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, state.satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, state.satisfiable_signals);
+  }
+  // |hv0| should have been closed when |h0| went out of scope, so this close
+  // should fail.
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(hv0));
+}
+
+TEST(MessagePipeTest, BasicWritingAndReading) {
+  MojoHandle hv0 = kInvalidHandleValue;
+  {
+    ScopedMessagePipeHandle h0;
+    ScopedMessagePipeHandle h1;
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h0, &h1));
+
+    const char kHello[] = "hello";
+    const uint32_t kHelloSize = static_cast<uint32_t>(sizeof(kHello));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h0.get(), kHello, kHelloSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+
+    MojoHandleSignalsState state;
+    EXPECT_EQ(MOJO_RESULT_OK, Wait(h1.get(), MOJO_HANDLE_SIGNAL_READABLE,
+                                   MOJO_DEADLINE_INDEFINITE, &state));
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE,
+              state.satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              state.satisfiable_signals);
+
+    char buffer[10] = {0};
+    uint32_t buffer_size = static_cast<uint32_t>(sizeof(buffer));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              ReadMessageRaw(h1.get(), buffer, &buffer_size, nullptr, nullptr,
+                             MOJO_READ_MESSAGE_FLAG_NONE));
+    EXPECT_EQ(kHelloSize, buffer_size);
+    EXPECT_STREQ(kHello, buffer);
+
+    // Send a handle over the previously-establish message pipe. Use the
+    // |MessagePipe| wrapper (to test it), which automatically creates a
+    // message pipe.
+    MessagePipe mp;
+
+    // Write a message to |mp.handle0|, before we send |mp.handle1|.
+    const char kWorld[] = "world!";
+    const uint32_t kWorldSize = static_cast<uint32_t>(sizeof(kWorld));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(mp.handle0.get(), kWorld, kWorldSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+
+    // Send |mp.handle1| over |h1| to |h0|.
+    MojoHandle handles[5];
+    handles[0] = mp.handle1.release().value();
+    EXPECT_NE(kInvalidHandleValue, handles[0]);
+    EXPECT_FALSE(mp.handle1.get().is_valid());
+    uint32_t handles_count = 1;
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h1.get(), kHello, kHelloSize, handles,
+                              handles_count, MOJO_WRITE_MESSAGE_FLAG_NONE));
+    // |handles[0]| should actually be invalid now.
+    EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(handles[0]));
+
+    // Read "hello" and the sent handle.
+    EXPECT_EQ(MOJO_RESULT_OK, Wait(h0.get(), MOJO_HANDLE_SIGNAL_READABLE,
+                                   MOJO_DEADLINE_INDEFINITE, &state));
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE,
+              state.satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              state.satisfiable_signals);
+
+    memset(buffer, 0, sizeof(buffer));
+    buffer_size = static_cast<uint32_t>(sizeof(buffer));
+    for (size_t i = 0; i < MOJO_ARRAYSIZE(handles); i++)
+      handles[i] = kInvalidHandleValue;
+    handles_count = static_cast<uint32_t>(MOJO_ARRAYSIZE(handles));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              ReadMessageRaw(h0.get(), buffer, &buffer_size, handles,
+                             &handles_count, MOJO_READ_MESSAGE_FLAG_NONE));
+    EXPECT_EQ(kHelloSize, buffer_size);
+    EXPECT_STREQ(kHello, buffer);
+    EXPECT_EQ(1u, handles_count);
+    EXPECT_NE(kInvalidHandleValue, handles[0]);
+
+    // Read from the sent/received handle.
+    mp.handle1.reset(MessagePipeHandle(handles[0]));
+    // Save |handles[0]| to check that it gets properly closed.
+    hv0 = handles[0];
+
+    EXPECT_EQ(MOJO_RESULT_OK,
+              Wait(mp.handle1.get(), MOJO_HANDLE_SIGNAL_READABLE,
+                   MOJO_DEADLINE_INDEFINITE, &state));
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE,
+              state.satisfied_signals);
+    EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE |
+                  MOJO_HANDLE_SIGNAL_PEER_CLOSED,
+              state.satisfiable_signals);
+
+    memset(buffer, 0, sizeof(buffer));
+    buffer_size = static_cast<uint32_t>(sizeof(buffer));
+    for (size_t i = 0; i < MOJO_ARRAYSIZE(handles); i++)
+      handles[i] = kInvalidHandleValue;
+    handles_count = static_cast<uint32_t>(MOJO_ARRAYSIZE(handles));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              ReadMessageRaw(mp.handle1.get(), buffer, &buffer_size, handles,
+                             &handles_count, MOJO_READ_MESSAGE_FLAG_NONE));
+    EXPECT_EQ(kWorldSize, buffer_size);
+    EXPECT_STREQ(kWorld, buffer);
+    EXPECT_EQ(0u, handles_count);
+  }
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(hv0));
+}
+
+// TODO(vtl): This is not the right level to test this at.
+TEST(MessagePipeTest, TearDownWithMessagesEnqueued) {
+  // Tear down a message pipe which still has a message enqueued, with the
+  // message also having a valid message pipe handle.
+  {
+    ScopedMessagePipeHandle h0;
+    ScopedMessagePipeHandle h1;
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h0, &h1));
+
+    // Send a handle over the previously-establish message pipe.
+    ScopedMessagePipeHandle h2;
+    ScopedMessagePipeHandle h3;
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h2, &h3));
+
+    // Write a message to |h2|, before we send |h3|.
+    const char kWorld[] = "world!";
+    const uint32_t kWorldSize = static_cast<uint32_t>(sizeof(kWorld));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h2.get(), kWorld, kWorldSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+    // And also a message to |h3|.
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h3.get(), kWorld, kWorldSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+
+    // Send |h3| over |h1| to |h0|.
+    const char kHello[] = "hello";
+    const uint32_t kHelloSize = static_cast<uint32_t>(sizeof(kHello));
+    MojoHandle h3_value;
+    h3_value = h3.release().value();
+    EXPECT_NE(kInvalidHandleValue, h3_value);
+    EXPECT_FALSE(h3.get().is_valid());
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h1.get(), kHello, kHelloSize, &h3_value, 1,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+    // |h3_value| should actually be invalid now.
+    EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(h3_value));
+
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h0.release().value()));
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h1.release().value()));
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h2.release().value()));
+  }
+
+  // Do this in a different order: make the enqueued message pipe handle only
+  // half-alive.
+  {
+    ScopedMessagePipeHandle h0;
+    ScopedMessagePipeHandle h1;
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h0, &h1));
+
+    // Send a handle over the previously-establish message pipe.
+    ScopedMessagePipeHandle h2;
+    ScopedMessagePipeHandle h3;
+    ASSERT_EQ(MOJO_RESULT_OK, CreateMessagePipe(nullptr, &h2, &h3));
+
+    // Write a message to |h2|, before we send |h3|.
+    const char kWorld[] = "world!";
+    const uint32_t kWorldSize = static_cast<uint32_t>(sizeof(kWorld));
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h2.get(), kWorld, kWorldSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+    // And also a message to |h3|.
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h3.get(), kWorld, kWorldSize, nullptr, 0,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+
+    // Send |h3| over |h1| to |h0|.
+    const char kHello[] = "hello";
+    const uint32_t kHelloSize = static_cast<uint32_t>(sizeof(kHello));
+    MojoHandle h3_value;
+    h3_value = h3.release().value();
+    EXPECT_NE(kInvalidHandleValue, h3_value);
+    EXPECT_FALSE(h3.get().is_valid());
+    EXPECT_EQ(MOJO_RESULT_OK,
+              WriteMessageRaw(h1.get(), kHello, kHelloSize, &h3_value, 1,
+                              MOJO_WRITE_MESSAGE_FLAG_NONE));
+    // |h3_value| should actually be invalid now.
+    EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(h3_value));
+
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h2.release().value()));
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h0.release().value()));
+    EXPECT_EQ(MOJO_RESULT_OK, MojoClose(h1.release().value()));
+  }
+}
+
+}  // namespace
+}  // namespace mojo